chore: Replace pbench support in the auto_hpl wrapper with PCP #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed pbench references from README.md - updated build_run_hpl.sh to work without pbench - verified script runs successfully after removal
sayalibhavsar
changed the title
malucius-rh
requested changes
Sep 11, 2025
malucius-rh
left a comment
malucius-rh
left a comment
There was a problem hiding this comment.
Global: replace $use_pcp with $to_use_pcp since the latter is provided by general_setup
sayalibhavsar
force-pushed
the
replace-pbench-with-pcp
branch
from
0f8b013 to
7d5cf49
Compare
Contributor
|
Need to use pcp_subtest for iterations, use results_to_pcp. |
sayalibhavsar
force-pushed
the
replace-pbench-with-pcp
branch
from
7d5cf49 to
9006270
Compare
malucius-rh
requested changes
Sep 29, 2025
sayalibhavsar
force-pushed
the
replace-pbench-with-pcp
branch
2 times, most recently
from
9abeb0e to
2421d30
Compare
dvalinrh
reviewed
Sep 30, 2025
dvalinrh
reviewed
Sep 30, 2025
dvalinrh
reviewed
Sep 30, 2025
dvalinrh
reviewed
Sep 30, 2025
dvalinrh
reviewed
Sep 30, 2025
dvalinrh
reviewed
Sep 30, 2025
malucius-rh
requested changes
Sep 30, 2025
malucius-rh
left a comment
malucius-rh
left a comment
There was a problem hiding this comment.
Need to see that the contents of the pcp archive are correct
sayalibhavsar
force-pushed
the
replace-pbench-with-pcp
branch
5 times, most recently
from
879fe36 to
67726eb
Compare
sayalibhavsar
force-pushed
the
replace-pbench-with-pcp
branch
from
67726eb to
e0991e5
Compare
dvalinrh
previously approved these changes
Sep 30, 2025
Contributor
dvalinrh
left a comment
dvalinrh
left a comment
There was a problem hiding this comment.
LGTM, needs verification and Matts approval.
Contributor
Author
custom metrics are captured |
|
I've seen Sayali's successful results after eliminating dots from metric names and reproduced them on one of my test systems. LGTM. |
malucius-rh
approved these changes
Oct 8, 2025
malucius-rh
left a comment
malucius-rh
left a comment
There was a problem hiding this comment.
Metrics are successfully collected in multiple environments. LGTM
malucius-rh
added
the
group_review_lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before/After Comparison
Before: the wrapper uses pbench
After: the wrapper uses pcp
Clerical Stuff
This closes #53 and #55
Relates to JIRA: RPOPC-600 and RPOPC-602