composite template deprecation #664
Conversation
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
| done | ||
| ``` | ||
|
|
||
| # ------------------------------------------------------------------- |
There was a problem hiding this comment.
Sorry for the specific call-out here. I don't know if you're the right person @Allda. I got distracted from working on this a couple of times today, so I put the note in here so I wouldn't lose it. 😁
There was a problem hiding this comment.
We already have a tracker for it and we will consolidate the documentation and the tooling (makefile) to provide a single way of interacting with catalogs and onboardings.
Could you please remove the comment so we can potentially merge it without the notes?
| "yaml", | ||
| os.path.join(operator.root, CATALOG_TEMPLATES_DIR, f"v{version}.yaml"), | ||
| ">", | ||
| f"../../catalogs/v{version}/catalog.yaml" |
There was a problem hiding this comment.
I think you're missing an operator name in the output path. Based on the design it should be ../../catalogs/v{version}/{operator-name}/catalog.yaml
| #catalog: semver | ||
| # | ||
| # --- COMPOSITE TEMPLATE --- | ||
| catalog: composite |
There was a problem hiding this comment.
With the removal of the composite as a default target for make catalog we should make the basic the default now.
|
There seem to be issues with test and linting. I'll push additional changes to your PR to fix it. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@grokspawn Hey, I didn't have a permission to update your PR and push new changes there so I created #671 which is based on your PR and adds some additional fixes and tests. Feel free to review it. |
Here's a quickie PR to demonstrate how redirecting the onboarding flows away from composite templates might look. If operator-framework/operator-registry#1335 merges, then existing FBC --> basic-template would be even simpler, as you could do
opm alpha convert-template basic $INFILE.I tried to cover all the bases, although I'm sure there's some context I'm missing and would be happy to learn about.