Skip to content

Conversation

@AlexXuChen
Copy link
Contributor

Added onDidGrantWorkspaceTrust event for downloadExternalResource setting.

Fixes #640 (comment)

Requires #640

Signed-off-by: Alexander Chen alchen@redhat.com

@AlexXuChen AlexXuChen force-pushed the downloadExternalResource-workspaceTrust branch from 3fa5eb4 to b8ac1bd Compare January 28, 2022 19:28
@AlexXuChen AlexXuChen force-pushed the downloadExternalResource-workspaceTrust branch 2 times, most recently from c22699f to f4a87ac Compare January 31, 2022 19:56
@AlexXuChen
Copy link
Contributor Author

#640 (comment) should behave as expected now:
workspacetrustdownloadexternal

@AlexXuChen AlexXuChen marked this pull request as ready for review January 31, 2022 20:49
@AlexXuChen AlexXuChen requested a review from rgrunber January 31, 2022 20:49
…ting

Signed-off-by: Alexander Chen <alchen@redhat.com>
@AlexXuChen AlexXuChen force-pushed the downloadExternalResource-workspaceTrust branch from f4a87ac to 2c76e75 Compare January 31, 2022 20:53
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexXuChen AlexXuChen merged commit 8f1f4a4 into redhat-developer:master Jan 31, 2022
@AlexXuChen AlexXuChen deleted the downloadExternalResource-workspaceTrust branch January 31, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants