-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize custom file extensions #3731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
reviewed
Aug 2, 2024
rgrunber
reviewed
Aug 2, 2024
snjeza
changed the title
Recognize custom file extensions
[WIP] Recognize custom file extensions
Aug 2, 2024
@rgrunber I have updated the PR. Could you, please, try now? |
snjeza
changed the title
[WIP] Recognize custom file extensions
Recognize custom file extensions
Aug 6, 2024
snjeza
changed the title
Recognize custom file extensions
[WIP] Recognize custom file extensions
Aug 7, 2024
@rgrunber I have update the PR. |
snjeza
changed the title
[WIP] Recognize custom file extensions
Recognize custom file extensions
Aug 7, 2024
rgrunber
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks fine to me. Just should be merged after the JDT-LS part is approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-jdtls/eclipse.jdt.ls#3222
Requires eclipse-jdtls/eclipse.jdt.ls#3230