Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @@ -0,0 +1,83 @@ | |||
| FROM centos:7 as build-tools | |||
There was a problem hiding this comment.
Haven't figured out how to use UBI here.
| SecretKeyRef: sks, | ||
| } | ||
| evn := strings.ToUpper(strings.ReplaceAll(instance.Name, "-", "_")) + "_" + strings.ToUpper(strings.ReplaceAll(key, "-", "_")) | ||
| evn := strings.ToUpper(strings.Replace(instance.Name, "-", "_", -1)) + "_" + strings.ToUpper(strings.Replace(key, "-", "_", -1)) |
There was a problem hiding this comment.
This is an unrelated change. Please use Go 1.12
There was a problem hiding this comment.
Ah ok! That explains it. Thanks.
| ConfigMapKeyRef: cmks, | ||
| } | ||
| evn := strings.ToUpper(strings.ReplaceAll(instance.Name, "-", "_")) + "_" + strings.ToUpper(strings.ReplaceAll(key, "-", "_")) | ||
| evn := strings.ToUpper(strings.Replace(instance.Name, "-", "_", -1)) + "_" + strings.ToUpper(strings.Replace(key, "-", "_", -1)) |
There was a problem hiding this comment.
This is an unrelated change. Please use Go 1.12
| build: ./out/operator | ||
|
|
||
| ./out/operator: | ||
| $(Q)CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build ${V_FLAG} -o ./out/operator cmd/manager/main.go No newline at end of file |
There was a problem hiding this comment.
operator-sdk build produce docker image with UBI as the base image.
Earlier we used go build as there was no way to pass build flags. But that is fixed in SDK: operator-framework/operator-sdk#1435
baijum
left a comment
baijum
left a comment
There was a problem hiding this comment.
Added a couple of comments. Dockerfile is not necessary.
|
Ok, where could I find the operator image built off master? |
As soon as you run But if the intent of this Makefile target is to use inside OpenShift CI like how we did it in DevConsole operator, then this will be required. |
|
@sbose78 You can use the |
|
Eventually the intent is to build it on ci and mirror images to Quay. But till we have that, I wish to setup master builds on Quay so that it could be used in the OperatorSource without having to locally build it and push it. |
|
( I will address the go1.12 comments ) |
|
If we really need a Dockerfile to be able to run this under OpenShift CI, we should find a automated way to extract the data from a |
|
@otaviof I have sent a PR to introduce building without OCI image: operator-framework/operator-sdk#1600 |
4 participants
make build