Skip to content

Conversation

@testetson22
Copy link
Contributor

@testetson22 testetson22 commented Feb 10, 2026

Add e2e tests covering entity-workflow integration (test cases RHIDP-11833 through RHIDP-11840):

  • Fix if condition nesting bug in orchestrator mountPoints config
  • Add orchestrator to pluginsWithPermission for RBAC enforcement
  • Add catalog locations for entity-workflow test templates
  • Add RBAC policies for catalogSuperuser test roles
  • Add page object methods for entity-workflow testing
  • Create orchestrator-entity-workflows.spec.ts
  • Create orchestrator-entity-rbac.spec.ts

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Add e2e tests covering entity-workflow integration
(test cases RHIDP-11833 through RHIDP-11840):

- Fix `if` condition nesting bug in orchestrator mountPoints config
- Add `orchestrator` to pluginsWithPermission for RBAC enforcement
- Add catalog locations for entity-workflow test templates
- Add RBAC policies for catalogSuperuser test roles
- Add page object methods for entity-workflow testing
- Create orchestrator-entity-workflows.spec.ts (TC-1 to TC-6)
- Create orchestrator-entity-rbac.spec.ts (TC-7, TC-8)
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gustavolira for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@testetson22
Copy link
Contributor Author

/test e2e-ocp-helm-nightly

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@github-actions
Copy link
Contributor

@testetson22
Copy link
Contributor Author

/test e2e-ocp-helm

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

- Use established navigation patterns (openSidebar instead of goToPageUrl)
- Use clickBtnInCard for template selection matching other tests
- Fix template name matching to actual catalog templates:
  - greeting.yaml: "Greeting workflow" (no annotation)
  - greeting_w_component.yaml: "Greeting Test Picker" (has annotation)
  - yamlgreet.yaml: "Greeting" (has annotation)
- Remove unconditional test.skip() to enable test execution
- Add proper wait states and retry logic for catalog sync
- Fix RHIDP-11835 negative test to use correct template without annotation

Relates-to: RHIDP-11833, RHIDP-11834, RHIDP-11835, RHIDP-11836,
RHIDP-11837, RHIDP-11838, RHIDP-11839, RHIDP-11840
@testetson22
Copy link
Contributor Author

/test e2e-ocp-helm-nightly

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@github-actions
Copy link
Contributor

@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2026

@testetson22: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 6677a7e link true /test e2e-ocp-helm
ci/prow/e2e-ocp-helm-nightly 6677a7e link false /test e2e-ocp-helm-nightly

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- Use clickLink({ ariaLabel: "Self-service" }) for global header navigation
- Use openSidebar() for sidebar items (Catalog, Orchestrator)
- Simplify template card selection using clickBtnInCard() helper
- Remove redundant XPath-based card visibility checks
- Fix catalog heading verification to match actual UI ("My Org Catalog")
- Fix workflow name references to match actual template names

The tests were failing because openSidebar("Self-service") looked for a
sidebar nav link, but Self-service is in the global header. Pattern now
matches catalog-timestamp.spec.ts and other working tests.

Relates-to: RHIDP-11833, RHIDP-11834, RHIDP-11835, RHIDP-11836,
RHIDP-11837, RHIDP-11838, RHIDP-11839, RHIDP-11840
@testetson22
Copy link
Contributor Author

/test e2e-ocp-helm-nightly

@rhdh-qodo-merge
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant