-
Notifications
You must be signed in to change notification settings - Fork 219
chore(ci): dynamically determine Chart version #4209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-ocp-helm-upgrade-nightly |
|
/test e2e-ocp-helm |
|
/test e2e-ocp-helm-upgrade-nightly |
|
The image is available at: |
|
|
||
| if [[ "$RELEASE_BRANCH_NAME" == "main" ]]; then | ||
| local chart_major_version | ||
| chart_major_version=$(curl -sSX GET "https://quay.io/api/v1/repository/rhdh/chart/tag/?onlyActiveTags=true&limit=100" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might fail the job on the release branch if we plan to backport it. There’s a chance that the next release CV won’t appear in the first 100 batches of the API request. For the next tag, it should work fine since it gets built frequently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This curl will be exercised only on the main branch, and I think that it's very unlikely, that the next (right now 1.10.) wouldn't show up in the first 100.
If we're on the release-x.y branch, it will just cut the x.y from the branch name and search for the tag using a filter the tags that contains x.y.
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
|
@zdrapela: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer