Skip to content

Conversation

@zdrapela
Copy link
Member

@zdrapela zdrapela commented Feb 6, 2026

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gustavolira for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdrapela
Copy link
Member Author

zdrapela commented Feb 6, 2026

/test e2e-ocp-helm-upgrade-nightly

@zdrapela
Copy link
Member Author

zdrapela commented Feb 6, 2026

/test e2e-ocp-helm

@zdrapela
Copy link
Member Author

zdrapela commented Feb 6, 2026

/test e2e-ocp-helm-upgrade-nightly
/test e2e-ocp-helm

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

@zdrapela zdrapela mentioned this pull request Feb 6, 2026
5 tasks
@zdrapela zdrapela marked this pull request as ready for review February 6, 2026 11:52
@openshift-ci openshift-ci bot requested review from kadel and rostalan February 6, 2026 11:52

if [[ "$RELEASE_BRANCH_NAME" == "main" ]]; then
local chart_major_version
chart_major_version=$(curl -sSX GET "https://quay.io/api/v1/repository/rhdh/chart/tag/?onlyActiveTags=true&limit=100" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might fail the job on the release branch if we plan to backport it. There’s a chance that the next release CV won’t appear in the first 100 batches of the API request. For the next tag, it should work fine since it gets built frequently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This curl will be exercised only on the main branch, and I think that it's very unlikely, that the next (right now 1.10.) wouldn't show up in the first 100.
If we're on the release-x.y branch, it will just cut the x.y from the branch name and search for the tag using a filter the tags that contains x.y.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🚫 Image Push Skipped.

The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2026

@zdrapela: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 7fba4a8 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants