Skip to content

Conversation

@zdrapela
Copy link
Member

@zdrapela zdrapela commented Feb 4, 2026

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from albarbaro and psrna February 4, 2026 14:52
@zdrapela
Copy link
Member Author

zdrapela commented Feb 4, 2026

/test e2e-ocp-operator-nightly

1 similar comment
@zdrapela
Copy link
Member Author

zdrapela commented Feb 4, 2026

/test e2e-ocp-operator-nightly

@zdrapela
Copy link
Member Author

zdrapela commented Feb 4, 2026

/test e2e-ocp-operator-nightly

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

@zdrapela
Copy link
Member Author

zdrapela commented Feb 4, 2026

/test e2e-ocp-operator-nightly

@zdrapela
Copy link
Member Author

zdrapela commented Feb 5, 2026

/test e2e-ocp-operator-nightly

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

@zdrapela
Copy link
Member Author

zdrapela commented Feb 5, 2026

/review

@rhdh-qodo-merge
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🔒 Security concerns

TLS verification disabled:
Multiple manifests set NODE_TLS_REJECT_UNAUTHORIZED to 0, which disables Node.js TLS certificate validation. This is risky if these resources can run outside a strictly controlled test environment. Ensure it is gated to E2E/CI-only deployments or replaced with proper CA trust configuration.

⚡ Recommended focus areas for review

YAML Schema

The Backstage CR is migrated to apiVersion: rhdh.redhat.com/v1alpha5 and now uses spec.deployment.patch. Please validate that the patch structure is correct for this Operator version (including containers/initContainers image overrides and the dynamic-plugins-root ephemeral PVC template), and that the extraEnvs entry for CATALOG_INDEX_IMAGE is correctly shaped (the nested containers field under an env var may not match the expected CRD schema and could be ignored or rejected).

kind: Backstage
apiVersion: rhdh.redhat.com/v1alpha5
metadata:
  name: rhdh
spec:
  deployment:
    patch:
      spec:
        template:
          spec:
            containers:
              - name: backstage-backend
                image: "quay.io/$QUAY_REPO:$TAG_NAME"
            initContainers:
              - name: install-dynamic-plugins
                image: "quay.io/$QUAY_REPO:$TAG_NAME"
            volumes:
              - name: dynamic-plugins-root
                ephemeral:
                  volumeClaimTemplate:
                    spec:
                      accessModes:
                        - ReadWriteOnce
                      resources:
                        requests:
                          storage: 5Gi
  application:
Test Coverage

Orchestrator plugins/workflows deployment is now skipped for Operator deployments and the E2E suites are marked fixme/skipped for several environments. Confirm CI still provides meaningful signal for Operator E2E (i.e., failures won’t be masked), and that the warning logs are sufficient to make the skip visible and intentional for release validation.

# TODO: https://issues.redhat.com/browse/RHDHBUGS-2184 fix orchestrator workflows deployment on operator
# enable_orchestrator_plugins_op "${NAME_SPACE}"
# deploy_orchestrator_workflows_operator "${NAME_SPACE}"
log::warn "Skipping orchestrator plugins and workflows deployment on Operator $NAME_SPACE deployment"
📄 References
  1. redhat-developer/rhdh-operator/config/scorecard/patches/olm.config.yaml [1-40]
  2. redhat-developer/rhdh-operator/config/scorecard/patches/basic.config.yaml [1-11]
  3. redhat-developer/rhdh-operator/config/scorecard/patches/olm.config.yaml [41-50]
  4. redhat-developer/rhdh-operator/bundle/backstage.io/tests/scorecard/config.yaml [5-47]
  5. redhat-developer/rhdh-operator/bundle/rhdh/tests/scorecard/config.yaml [5-47]
  6. redhat-developer/rhdh-operator/bundle/backstage.io/tests/scorecard/config.yaml [48-57]
  7. redhat-developer/rhdh-operator/bundle/backstage.io/tests/scorecard/config.yaml [58-67]
  8. redhat-developer/rhdh-operator/bundle/rhdh/tests/scorecard/config.yaml [48-57]

@zdrapela
Copy link
Member Author

zdrapela commented Feb 5, 2026

/test e2e-ocp-operator-nightly

@zdrapela
Copy link
Member Author

zdrapela commented Feb 5, 2026

/test e2e-eks-operator-nightly

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

@zdrapela
Copy link
Member Author

zdrapela commented Feb 5, 2026

/test e2e-eks-operator-nightly

@zdrapela
Copy link
Member Author

zdrapela commented Feb 5, 2026

/test e2e-ocp-operator-nightly

@subhashkhileri
Copy link
Member

review same as #4186 since the change is similar

@zdrapela
Copy link
Member Author

zdrapela commented Feb 6, 2026

/test e2e-ocp-helm

@subhashkhileri
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 6, 2026
@zdrapela
Copy link
Member Author

zdrapela commented Feb 6, 2026

/test e2e-ocp-helm

@zdrapela
Copy link
Member Author

zdrapela commented Feb 7, 2026

/test e2e-ocp-helm

2 similar comments
@zdrapela
Copy link
Member Author

zdrapela commented Feb 8, 2026

/test e2e-ocp-helm

@zdrapela
Copy link
Member Author

zdrapela commented Feb 8, 2026

/test e2e-ocp-helm

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2026

@zdrapela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-eks-operator-nightly dea24d1 link false /test e2e-eks-operator-nightly
ci/prow/e2e-ocp-operator-nightly dea24d1 link false /test e2e-ocp-operator-nightly
ci/prow/e2e-ocp-helm dea24d1 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants