fix(e2e): add search filter to reduce catalog test flakiness

[HusneShabbir]

Adds search filter before selecting catalog items to reduce test flakiness.

Changes

• Add search input to filter results before selection

Why

Reduces flaky failures by ensuring the correct item is targeted when multiple results exist.

[rhdh-qodo-merge]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Wait After filling the search input, the code immediately clicks the link. If results are filtered asynchronously (debounce, network request, client-side rendering), the click may race with the UI update. Consider waiting for the filtered item to be visible/enabled (or for the list to settle) before clicking. async goToByName(name: string) { await this.uiHelper.openCatalogSidebar("Component"); await this.page.getByRole("textbox", { name: "Search" }).fill(name); await this.uiHelper.clickLink(name);

📚 Focus areas based on broader codebase context i18n Selector The new search step uses a hardcoded accessible name (getByRole("textbox", { name: "Search" })), which can break under localization or minor UI copy changes. Prefer the existing semantic search selector/helper used elsewhere (label/placeholder derived from translations) to keep the selector stable and consistent across tests. (Ref 4, Ref 1) async goToByName(name: string) { await this.uiHelper.openCatalogSidebar("Component"); await this.page.getByRole("textbox", { name: "Search" }).fill(name); await this.uiHelper.clickLink(name); } Reference reasoning: The codebase already centralizes search input selection via a semantic helper that resolves the search title from translations and falls back between label and placeholder, and other catalog tests use dedicated UI helper search methods. Reusing those patterns avoids hardcoded English strings and reduces selector brittleness.

📄 References redhat-developer/rhdh/e2e-tests/playwright/e2e/catalog-timestamp.spec.ts [1-86] redhat-developer/rhdh/e2e-tests/playwright/e2e/github-discovery.spec.ts [24-55] redhat-developer/rhdh/e2e-tests/playwright/support/pages/bulk-import.ts [5-61] redhat-developer/rhdh/e2e-tests/playwright/support/page-objects/page-obj.ts [46-84] redhat-developer/rhdh/e2e-tests/playwright/support/pages/catalog-import.ts [17-107] redhat-developer/rhdh/e2e-tests/playwright/support/pages/catalog-item.ts [1-20] redhat-developer/rhdh/e2e-tests/playwright/e2e/extensions.spec.ts [14-851] redhat-developer/rhdh/e2e-tests/playwright/e2e/default-global-header.spec.ts [12-206]

[rhdh-qodo-merge]

PR Type

Bug fix, Tests

---

Description

• Add search filter to catalog selection in e2e tests

• Reduces test flakiness by targeting correct items when multiple results exist

---

File Walkthrough

	Relevant files
Tests	catalog.ts Add search filter before catalog item selection                    e2e-tests/playwright/support/pages/catalog.ts Added search input fill before clicking catalog item link Filters catalog results by name to ensure correct item selection Improves test reliability when multiple matching items exist +1/-0

---

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rhdh-qodo-merge]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Wait for filtered result to appear Add a page.waitForSelector after filling the search input to ensure the filtered result is visible before attempting to click it, preventing test flakiness. e2e-tests/playwright/support/pages/catalog.ts [23] await this.page.getByRole("textbox", { name: "Search" }).fill(name); +await this.page.waitForSelector(`text="${name}"`, { state: "visible" }); Apply / Chat Suggestion importance[1-10]: 7 __ Why: This suggestion correctly identifies a potential race condition and proposes a robust solution by waiting for the element to be visible, which improves test stability.	Medium
General	Scope search locator to sidebar Scope the search input locator to the catalog sidebar panel to make it more specific and prevent potential conflicts if other search inputs exist on the page. e2e-tests/playwright/support/pages/catalog.ts [23] -await this.page.getByRole("textbox", { name: "Search" }).fill(name); +const catalogPanel = this.page.locator('aside[aria-label="Component catalog"]'); +const searchInput = catalogPanel.getByRole("textbox", { name: "Search" }); +await searchInput.fill(name); Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion improves the locator's specificity, making the test more robust against future UI changes by preventing potential conflicts with other search inputs.	Low
More

[teknaS47]

/lgtm

[github-actions]

The image is available at:

• quay.io/rhdh-community/rhdh:pr-4166
• quay.io/rhdh-community/rhdh:pr-4166-8ad9914d

[HusneShabbir]

/cc @christoph-jerolimov @jrichter1

[jrichter1]

/approve

[christoph-jerolimov]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, jrichter1, teknaS47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• e2e-tests/OWNERS [christoph-jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[christoph-jerolimov]

/cherry-pick release-1.9

[openshift-cherrypick-robot]

@christoph-jerolimov: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@christoph-jerolimov: new pull request created: #4167

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.