Skip to content

Conversation

@nickboldt
Copy link
Member

@nickboldt nickboldt commented Nov 12, 2025

What does this PR do?

chore(catalog migration): move all the packages to the overlays repo

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

RHIDP-8936, RHIDP-9446

How to test this PR?

Content was generated using this script: https://gitlab.cee.redhat.com/rhidp/rhdh-plugin-catalog/-/merge_requests/440/diffs

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt nickboldt changed the title chore(catalog migration): move all the... chore(catalog migration): move all the packages to the overlays repo (RHIDP-8936) Nov 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divyanshigupta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt marked this pull request as draft November 12, 2025 20:53
@nickboldt nickboldt changed the title chore(catalog migration): move all the packages to the overlays repo (RHIDP-8936) chore(catalog migration): move all the packages to the overlays repo (RHIDP-8936, RHIDP-9446) Nov 12, 2025
@github-actions
Copy link
Contributor

@nickboldt
Copy link
Member Author

David said in slack:

all is well for me

@nickboldt nickboldt marked this pull request as ready for review November 13, 2025 18:03
@openshift-ci openshift-ci bot requested review from 04kash and PatAKnight November 13, 2025 18:03
@nickboldt nickboldt merged commit ce1f10f into main Nov 13, 2025
23 of 25 checks passed
@nickboldt nickboldt deleted the RHIDP-8936 branch November 13, 2025 18:03
@rhdh-qodo-merge
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
🟢
No codebase code duplication found No new components were introduced in the PR code
Custom Compliance
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
Deletions Only: The PR only deletes catalog YAML files and adds no new code or logging, so it's
unclear whether required audit logging for critical actions is impacted or preserved
elsewhere.

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status:
No New Code: This PR introduces no new identifiers; only deletions of YAML package descriptors occur,
so naming compliance cannot be assessed from the diff.

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No Error Paths: The diff contains only file removals with no executable logic added or modified, so error
handling and edge cases cannot be evaluated.

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status:
No User Errors: No user-facing error messages were added or modified in this PR, so secure error handling
cannot be assessed from the provided changes.

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status:
No New Logs: The PR does not introduce or modify logging statements; only YAML files are removed, so
logging practices cannot be evaluated from the diff.

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
No Inputs Changed: With only deletions of catalog YAML descriptors and no new input-handling code, input
validation and data handling compliance cannot be determined from this PR.

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant