fix(orchestrator): pass businessKey for assessments #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
mareklibra
changed the title
batzionb
approved these changes
Nov 26, 2024
|
@mareklibra |
mareklibra
force-pushed
the
FLPATH-1881.backport.passBusinnessKey.AssignedBy
branch
from
b7ae5f7 to
dabd13f
Compare
Changed Packages
|
|
The prettier is passing when executed in the plugin's folder but not on the workspace level. I will try to fix that in a separate PR. |
|
meanwhile can you fix it so we can get this merged? |
batzionb
reviewed
Nov 28, 2024
| @@ -89,7 +90,7 @@ export const ExecuteWorkflowPage = () => { | |||
| const response = await orchestratorApi.executeWorkflow({ | |||
| workflowId, | |||
| parameters, | |||
| businessKey: assessmentInstanceId, | |||
| businessKey: effectiveInstanceId, | |||
There was a problem hiding this comment.
Suggested change
| businessKey: effectiveInstanceId, | |
| businessKey: assessmentInstanceId, |
batzionb
reviewed
Nov 28, 2024
| @@ -98,7 +99,7 @@ export const ExecuteWorkflowPage = () => { | |||
| setIsExecuting(false); | |||
| } | |||
| }, | |||
| [orchestratorApi, workflowId, navigate, instanceLink, assessmentInstanceId], | |||
| [orchestratorApi, workflowId, navigate, instanceLink, effectiveInstanceId], | |||
There was a problem hiding this comment.
Suggested change
| [orchestratorApi, workflowId, navigate, instanceLink, effectiveInstanceId], | |
| [orchestratorApi, workflowId, navigate, instanceLink, assessmentInstanceId], |
Fixes: FLPATH-1881 With this change, the "Assessed by" link is shown. Signed-off-by: Marek Libra <mlibra@redhat.com>
mareklibra
force-pushed
the
FLPATH-1881.backport.passBusinnessKey.AssignedBy
branch
from
dabd13f to
4c4fd8e
Compare
mareklibra
force-pushed
the
FLPATH-1881.backport.passBusinnessKey.AssignedBy
branch
from
2347cf2 to
6471a68
Compare
batzionb
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of janus-idp/backstage-plugins#2558