Skip to content

Conversation

johnmcollier
Copy link
Member

Hey, I just made a Pull Request!

This PR copies over @thepetk's techdocs-mcp-tool plugin originally present on the redhat-ai-dev fork. No changes to the plugin have been made.

I've also updated the app-config in the workspace to reference the new plugin, and Cursor shows all of the MCP tools when connected to the MCP server:

Screenshot 2025-09-23 at 2 53 53 PM

However, the tests from the techdocs tool are failing and need investigation

CC @thepetk

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

johnmcollier and others added 2 commits September 23, 2025 14:52
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Sep 23, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/mcp-integrations/packages/app none v0.0.0
backend workspaces/mcp-integrations/packages/backend none v0.0.0
@red-hat-developer-hub/backstage-plugin-software-catalog-mcp-tool workspaces/mcp-integrations/plugins/software-catalog-mcp-tool patch v0.2.0
@redhat-developer-hub/backstage-plugin-techdocs-mcp-tool workspaces/mcp-integrations/plugins/techdocs-mcp-tool patch v0.1.0

Signed-off-by: John Collier <jcollier@redhat.com>
@johnmcollier
Copy link
Member Author

The specific test failure in techdocs plugin:

     TypeError: Cannot read properties of undefined (reading 'getPluginRequestToken')

      268 |       const fetch = this.fetchFunction || (await import('node-fetch')).default;
      269 |       const headers: Record<string, string> = {};
    > 270 |       const { token } = await auth.getPluginRequestToken({
          |                                    ^
      271 |         onBehalfOf: await auth.getOwnServiceCredentials(),
      272 |         targetPluginId: 'techdocs',
      273 |       });

@thepetk
Copy link
Contributor

thepetk commented Sep 24, 2025

Failing test cases should be addressed by: redhat-ai-dev/community-plugins#6

cc @johnmcollier

Signed-off-by: John Collier <jcollier@redhat.com>
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
@johnmcollier johnmcollier force-pushed the addtechdocspluginfromfork branch from 54ad293 to 69c45f7 Compare September 24, 2025 15:55
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm based also on my tests locally. Regarding the sonar cloud error I'm not sure if is a good idea to remove the regex mentioned.

@johnmcollier
Copy link
Member Author

Rebasing on main before merging

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@johnmcollier johnmcollier merged commit 5df06ee into redhat-developer:main Sep 24, 2025
9 of 10 checks passed
Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies did not get to this before you all wrapped up but fwiw I saw no issues / had no comments post merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants