-
Notifications
You must be signed in to change notification settings - Fork 74
feat(i18n): add translation support to homepage plugin #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): add translation support to homepage plugin #1467
Conversation
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small suggestions. I think we don't need the trans component. Wdyt?
workspaces/homepage/plugins/dynamic-home-page/src/components/EntitySection/EntitySection.tsx
Show resolved
Hide resolved
workspaces/homepage/plugins/dynamic-home-page/src/components/FeaturedDocsCard.tsx
Outdated
Show resolved
Hide resolved
...spaces/homepage/plugins/dynamic-home-page/src/components/TemplateSection/TemplateSection.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. I just believe we don't need the trans component. Wdyt?
Signed-off-by: Rohit Rai <rohitkrai03@gmail.com>
ac79450
to
e08bcde
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
featuredDocs.learnMore
contains still a prefix space but we can merge it anyway now to rebase other PRs.
Thanks @rohitkrai03 👍
8b64e16
into
redhat-developer:main
Hey, I just made a Pull Request!
Fixes - https://issues.redhat.com/browse/RHIDP-8780
Added internationalization (i18n) support to Homepage plugin
@backstage/core-plugin-api/alpha
usingcreateTranslationRef
, translation resources, and semantic key structures with parameter interpolationmockTranslations.ts
) that use actual English strings as single source of truth - can be copied to other pluginsThe plugin now supports multiple languages with proper fallbacks and maintains all existing functionality. The translation infrastructure and test patterns established here can be reused across other Backstage plugins.
Languages added:
Screen.Recording.2025-09-18.at.2.01.20.AM.mov
✔️ Checklist