ci: Fix the changed files detection when running some of the Workflows #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, for some reason, no change would be detected. This was noticed in several PRs where, for example, container images should have been built but were skipped because the diff was working against the base commit at the time the PR was created, with errors similar to the following in the logs [1]: ``` fatal: Invalid revision range 5df8826..5f05431 Changed files for this commit: ============================== ============================== ``` This should hopefully fix that behavior, by delegating to this dedicated Action. [1] https://github.com/redhat-developer/rhdh-operator/actions/runs/12637951503/job/35213226116?pr=609#step:3:20
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b086e66
into
redhat-developer:main
7 checks passed
rm3l
deleted the
fix_changed_files_detection_when_running_ci_workflows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, for some reason, no change would be detected.
This was noticed in several PRs where, for example, container images should have been built but were skipped because the diff was being executed against the base commit at the time the PR was created, with errors similar to the following in the logs [1]:
This should hopefully fix that behavior, by delegating to https://github.com/tj-actions/changed-files.
The way the exclusion and inclusion rules are defined also makes the Workflows much more legible.
[1] https://github.com/redhat-developer/rhdh-operator/actions/runs/12637951503/job/35213226116?pr=609#step:3:20
Which issue(s) does this PR fix or relate to
https://github.com/redhat-developer/rhdh-operator/actions/runs/12637951503/job/35213226116?pr=609#step:3:20
PR acceptance criteria
rhdh-operator.clusterserviceversion.yamlfile accordinglyHow to test changes / Special notes to the reviewer
Let's see if this works.