Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Che on osio should support wildfly redhat version (currently community version is used) #723

Closed
2 tasks
ibuziuk opened this issue Jun 27, 2018 · 12 comments
Closed
2 tasks

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jun 27, 2018

Wildfly swarm Repos for the Redhat Version

@animuk
Copy link

animuk commented Jun 28, 2018

Wildfly swarm Repos for the Redhat Version

  1. HealthCheck Boosters : https://github.com/wildfly-swarm-openshiftio-boosters/wfswarm-health-check-redhat
  2. Rest HTTP Boosters : https://github.com/wildfly-swarm-openshiftio-boosters/wfswarm-rest-http-redhat

Issue Description:

  • if you import the HealthCheck Booster above within Che workspace,
    1. Auto Compile Feature does not work. ( Please Note : Build and Run is working as expected ).
  • If you import Rest HTTP Booster above within the che workspace, Two issues we can see at the moment -
    1. Auto Compile Feature does not work ( Please Note : Build and Run is working as expected ).

please note: here autocompile means hot deployment on any code change

@animuk
Copy link

animuk commented Jun 28, 2018

Some times I can see, Maven Build issue is coming within che workspace due to lack of memory. and this happens because of this switch "MAVEN_OPTS='-Xmx100m'" while building within che.

You may want to increase the memory allocation

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 28, 2018

@animuk in terms of memory settings, there is a separate issue - #674

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 28, 2018

Two issues we can see at the moment

@animuk Might miss smth. but there is only one issue listed (auto-compile / hot deployment does not work). BTW, does auto compile / hot-deployment works for this wildfly projects OOTB locally against desktop IDE e.g. for spring-boot / vert.x hot deployment works differently [1]

[1] #254 (comment)

@ibuziuk ibuziuk changed the title Need to switch to wildfly redhat version Che should support wildfly redhat version (currently community version is used) Jun 28, 2018
@ibuziuk ibuziuk changed the title Che should support wildfly redhat version (currently community version is used) che on osio should support wildfly redhat version (currently community version is used) Jun 28, 2018
@animuk
Copy link

animuk commented Jul 2, 2018

@ibuziuk For config map boosters as below repo:
https://github.com/wildfly-swarm-openshiftio-boosters/wfswarm-configmap-redhat

In Che workspace -

  1. Imported Successfully
  2. dev-machine - build Successfully
  3. dev-machine - run Successfully

But Issue is the config map URL - invoke service does not work ( but this is working perfectly in the pipeline). Please check from your side.
screenshot from 2018-07-02 16-32-59

@animuk
Copy link

animuk commented Jul 2, 2018

To Summerize -

  1. Need to set correct maven options - memory options for (wildflyswarm) boosters . Ref Issue : Fix wildfly booster - set correct maven options #674
  2. for wildfly -config map booster, URL - invoke service does not work in che.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 2, 2018

@animuk what about the Auto Compile ? Does it work locally for wildfly ?

@ibuziuk ibuziuk changed the title che on osio should support wildfly redhat version (currently community version is used) Che on osio should support wildfly redhat version (currently community version is used) Jul 2, 2018
@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 2, 2018

@animuk unfortunately, we will not be able to address all the issue in the next sprint. But we are planning to start with #674

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 4, 2018

@slemeur @l0rd I just had a blue jins seesion with @animuk and this tasks are requested to be done in the next sprint. Are you ok to take this into the next sprint backlog ? The first part about increasing ram options would not require a lot of time (just a command update) The second one could be trickier and would probably require a few days of investigation

@amisevsk
Copy link
Collaborator

amisevsk commented Jul 4, 2018

One note about the configmap issue -- while working on updating the rhdev/che-dockerfiles for https://github.com/redhat-developer/che-dockerfiles/pull/37, I found that there appears to be no officially supported version for the wildfly-swarm configmap booster on OSIO. This can be confirmed by checking the REST endpoint:

curl -H "X-App: osio" https://forge.api.openshift.io/api/booster-catalog | jq '.boosters | .[] | select(.mission == "configmap" and .runtime == "wildfly-swarm")'

I don't know if this affects the discussion.

@animuk
Copy link

animuk commented Jul 6, 2018

@amisevsk Yes. Currently, It is not there. But, We want to include that in the OSIO booster catalog so that config map booster will be available.

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 2, 2019

Closing as outdated

@ibuziuk ibuziuk closed this as completed Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants