Use devstats.PID.json as devstate

[feloy]

What type of PR is this:

/kind feature

What does this PR do / why we need it:

State of odo dev if now saved in a file .odo/devstate.${PID}.json, to be able to run multiple instances and state for each of them.

For compatibility, the file .odo/devstate.json is also used for the first instance of odo dev.

One drawback is that if an instance of odo dev is killed, the devstate.json file won't be overwritten. One possibility would be to delete it when running odo delete component and the process with registered PID into devstate.json is not existing.

Which issue(s) this PR fixes:

Fixes #6494

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

[netlify]

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	0877169
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/643ea97eca09220008413403

[odo-robot]

NoCluster Tests on commit 18d94d6 finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Unauthenticated Tests on commit 18d94d6 finished successfully.
View logs: TXT HTML

[odo-robot]

Unit Tests on commit 18d94d6 finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit 18d94d6 finished successfully.
View logs: TXT HTML

[odo-robot]

Windows Tests (OCP) on commit 18d94d6 finished with errors.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit 18d94d6 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit 18d94d6 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Docs Tests on commit 0dc2f4d finished successfully.
View logs: TXT HTML

[feloy]

Thanks @rm3l for your review

[feloy]

Investigating this error:

On Windows, it seems that the second process detects correctly that a first process exists.
But at the time of stopping the first process at the end of the test, an error occurs.

WaitForDevModeToContain fails when the process terminates.

[FAILED] [66.184 seconds]
odo dev command tests when a component with multiple endpoints is run [It] should fail running a second session on the same platform
C:/Users/Administrator.ANSIBLE-TEST-VS/3707/tests/integration/cmd_dev_test.go:3081

[...]

 [odo]   __
  [odo]  /  \__     Developing using the "ijoreq" Devfile
  [odo]  \__/  \    Namespace: cmd-dev-test3081fac
  [odo]  /  \__/    odo version: v3.9.0
  [odo]  \__/
  [odo] 
  [odo] - Running on the cluster in Dev mode
  [odo]  X  unable to save state file: a session with PID 11436 is already running on platform "cluster"

[...]

[FAILED] Unexpected error:
      <*fmt.wrapError | 0xc001fd6260>: {
          msg: "calling GenerateConsoleCtrlEvent: The parameter is incorrect.",
          err: <syscall.Errno>0x57,
      }
      calling GenerateConsoleCtrlEvent: The parameter is incorrect.
  occurred
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3707/tests/helper/helper_dev.go:195 @ 04/17/23 03:58:31.703

[rm3l]

Works great - thanks!

[rm3l]

@feloy Can you rebase your branch onto main? I was about to re-lgtm this PR, but noticed it has a conflict.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

[feloy]

/override windows-integration-test/Windows-test
Flaky tests

[openshift-ci]

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test
Flaky tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.