Support dev.odo.push.path:* attributes on Podman#6576
Merged
openshift-merge-robot merged 6 commits intoredhat-developer:mainfrom Feb 8, 2023
Merged
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
…xed with 'dev.odo.push.path' We were looking into the run command attributes only, while all this could also apply to the debug command too. Co-authored-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
This way, it can be reused in all platform-specific implementations. Co-authored-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
Co-authored-by: Parthvi Vala <pvala@redhat.com>
rm3l
force-pushed
the
6492-support-dev.odo.push.path-attribute-on-podman
branch
from
d46c9a2 to
a16059d
Compare
rm3l
added
kind/feature
rm3l
changed the title
dev.odo.push.path:* attributes on Podman
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
valaparthvi
suggested changes
Feb 8, 2023
Contributor
valaparthvi
left a comment
valaparthvi
left a comment
There was a problem hiding this comment.
One small change, else looks good.
Comment on lines
272
to
275
| cmdName := parameters.DevfileRunCmd | ||
| if parameters.Debug { | ||
| cmdKind = devfilev1.DebugCommandGroupKind | ||
| cmdName = parameters.DevfileDebugCmd | ||
| } |
Contributor
There was a problem hiding this comment.
Can we move cmdName along with cmdKind as well for a better readability?
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
/lgtm |
openshift-ci
bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @valaparthvi
What type of PR is this:
/kind feature
/area odo-on-podman
What does this PR do / why we need it:
This adds support for command-level attributes prefixed with
dev.odo.push.path:on Podman. See #6492 and the doc for more context.While working on this issue, we also found out that
odowas always picking the attributes of theruncommand, regardless of whether users were running in Debug or not. This PR also fixes that behavior, by making sure we pick the right command attributes.Which issue(s) this PR fixes:
Fixes #6492
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See https://deploy-preview-6576--odo-docusaurus-preview.netlify.app/docs/user-guides/advanced/pushing-specific-files. This should now work on Podman.