Skip to content

Add more tests for odo dev on Podman (3) #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 8 commits into from
Jan 19, 2023
Merged

Add more tests for odo dev on Podman (3) #6515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
27b3d2e
Change DevModeShouldFail signature
feloy Jan 16, 2023
67f5e07
Use component.Exec for remoteFileChecker
feloy Jan 19, 2023
34cfdda
Test run failures on podman
feloy Jan 16, 2023
1ceba78
Test odo dev with custom run commands
rm3l Jan 16, 2023
9c5d2f0
Test "Create and dev java-springboot component" on Podman as well
feloy Jan 19, 2023
1e761bb
Test "running odo dev --no-watch and build command throws an error" o…
feloy Jan 19, 2023
7f0c198
Test "running odo dev and run command throws an error" on Podman as well
feloy Jan 19, 2023
629ef0e
Test "running odo dev and prestart events are defined" on Podman as well
feloy Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/examples/source/devfiles/springboot/devfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ starterProjects:
components:
- name: tools
container:
image: quay.io/eclipse/che-java11-maven:next
image: registry.access.redhat.com/ubi8/openjdk-11:latest
memoryLimit: 768Mi
command: ['tail']
args: [ '-f', '/dev/null']
Expand All @@ -22,7 +22,7 @@ components:
path: /data/cache/.m2
- name: runtime
container:
image: quay.io/eclipse/che-java11-maven:next
image: registry.access.redhat.com/ubi8/openjdk-11:latest
memoryLimit: 768Mi
endpoints:
- name: "8080-tcp"
Expand Down
10 changes: 7 additions & 3 deletions tests/helper/helper_dev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,14 @@ func RunDevMode(options DevSessionOpts, inside func(session *gexec.Session, outC
// `odo dev` runs in an infinite reconciliation loop, and hence running it with Cmd will not work for a lot of failing cases,
// this function is helpful in such cases.
// TODO(pvala): Modify StartDevMode to take substring arg into account, and replace this method with it.
func DevModeShouldFail(envvars []string, substring string, opts ...string) (DevSession, []byte, []byte, error) {
func DevModeShouldFail(options DevSessionOpts, substring string) (DevSession, []byte, []byte, error) {
args := []string{"dev", "--random-ports"}
args = append(args, opts...)
session := Cmd("odo", args...).AddEnv(envvars...).Runner().session
args = append(args, options.CmdlineArgs...)
if options.RunOnPodman {
args = append(args, "--platform", "podman")
options.EnvVars = append(options.EnvVars, "ODO_EXPERIMENTAL_MODE=true")
}
session := Cmd("odo", args...).AddEnv(options.EnvVars...).Runner().session
WaitForOutputToContain(substring, 360, 10, session)
result := DevSession{
session: session,
Expand Down
Loading