Skip to content

[WIP] Add more tests for odo dev on Podman#6482

Closed
rm3l wants to merge 27 commits intoredhat-developer:mainfrom
rm3l:6447-add-more-tests-for-odo-dev-on-podman
Closed

[WIP] Add more tests for odo dev on Podman#6482
rm3l wants to merge 27 commits intoredhat-developer:mainfrom
rm3l:6447-add-more-tests-for-odo-dev-on-podman

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Jan 10, 2023

  • Implement GetRunningPodFromSelector for podman
  • Implement GetPodLogs for podman
  • Same message in podman/cluster
  • Integration tests
  • WIP - test cases with composite commands
  • WIP - refactor GetEnvVars
  • wip : Add GetLabels interface method in component_interface

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6447

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 538b048
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63c583f04c3d0d000803a9c1

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

NoCluster Tests on commit 1456cd9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

OpenShift Tests on commit 1456cd9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

Unit Tests on commit 1456cd9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

Validate Tests on commit 1456cd9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

Windows Tests (OCP) on commit 1456cd9 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 10, 2023

Kubernetes Tests on commit 1456cd9 finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member Author

rm3l commented Jan 10, 2023

/hold

Created on top of #6481. We need to wait for #6481.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jan 10, 2023
@rm3l rm3l changed the title 6447 add more tests for odo dev on podman [WIP] Add more tests for odo dev on Podman Jan 10, 2023
@rm3l rm3l added the area/odo-on-podman Issues or PRs related to running odo against Podman label Jan 10, 2023
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd anandrkskd force-pushed the 6447-add-more-tests-for-odo-dev-on-podman branch from 4913b54 to 9db6945 Compare January 11, 2023 06:11
@feloy feloy force-pushed the 6447-add-more-tests-for-odo-dev-on-podman branch from f78763d to 5a825c1 Compare January 11, 2023 09:44
@feloy feloy force-pushed the 6447-add-more-tests-for-odo-dev-on-podman branch from 6d8341f to 703dc52 Compare January 16, 2023 09:55
rm3l and others added 8 commits January 16, 2023 11:11
NOTE: Previous container image (quay.io/eclipse/che-java11-maven:next) was not working on Podman due to permission errors.
We changed the image to the same one used on the Devfile public registry: registry.access.redhat.com/ubi8/openjdk-11:latest

Example of output:
```
[odo] ↪ Running on podman in Dev mode
[odo]  •  Deploying pod  ...
 ✓  Deploying pod [35s]
[odo]  ✗  Command 'tar xf - -C /projects --no-same-owner' in container failed.
...
[odo]  ✗  failed to sync to component with name java-spring-boot: unable push files to pod: exit status 2
```
…p" function

This allows such specs to be visible in the report, without failing the suite.
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jan 16, 2023
@openshift-merge-robot
Copy link
Collaborator

@rm3l: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member Author

rm3l commented Jan 19, 2023

@rm3l rm3l closed this Jan 19, 2023
@rm3l rm3l deleted the 6447-add-more-tests-for-odo-dev-on-podman branch January 19, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/odo-on-podman Issues or PRs related to running odo against Podman do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more tests for odo dev on podman

5 participants