fix: The plaintext rendering color on the completion document is too dark.#370
Open
angelozerr wants to merge 1 commit intoredhat-developer:mainfrom
Open
fix: The plaintext rendering color on the completion document is too dark.#370angelozerr wants to merge 1 commit intoredhat-developer:mainfrom
angelozerr wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
dark. Fixes redhat-developer#368 Signed-off-by: azerr <azerr@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 22.41% 24.38% +1.96%
==========================================
Files 270 270
Lines 9725 9408 -317
Branches 1830 1734 -96
==========================================
+ Hits 2180 2294 +114
+ Misses 7138 6687 -451
- Partials 407 427 +20 ☔ View full report in Codecov by Sentry. |
Contributor
Author
Contributor
|
I think we should keep the code blocks. That's how intellij shows code snippets LSP4IJ's behavior is consistent with that. Maybe @CppCXY's issue is the block's background seems darker on completion, compared to hover. Not sure what we can do about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fix: The plaintext rendering color on the completion document is too dark.
Fixes #368