Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support idea IJ Version 2024.1.x #164

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

zvigrinberg
Copy link
Collaborator

@zvigrinberg zvigrinberg commented Aug 2, 2024

This PR is due to a new error raised in 2024.1.x for AnAction Actions in Intelli-J plugin SDK framework:

the IJ version 2024.1.x on latest build brutally deprecated the OLD_EDT ( Old Event Dispatcher Thread) Action update Thread, with an exception ( No warning to replace it ASAP in logs, but error exception that stops the plugin from being loaded and function properly), plugins that has actions of kind AnAction must explicitly choose in code for each action, whether they use BGT( Background Thread) or EDT thread for update actions ( the plugin has two actions - Stack Analysis action for invoking analysis and getting HTML report and Image Analysis for invoking the batch analysis on Dockerfile' Base Image ) .
This PR contains the needed changes to support this change - After that the error is gone.

But this one requires regression over go manifests ( in ultimate editions of IntelliJ) and Dockerfile base image scanning...
And also need to adjust the workflows accordingly to this new version bump of the Intelli-J framework version.

In addition, since the action code for generating the stack analysis HTML Report was changed, there is a need to do regressions tests on HTML report generation.

@xieshenzh
Copy link
Collaborator

I think the compatibility will be affected: https://intellij-support.jetbrains.com/hc/en-us/community/posts/18697727524754/comments/18765441074962

241.14494.240 is for 2024.1+, maybe we could use 2022.3+ instead.

And we could also update the idea version: https://github.com/search?q=repo%3Aredhat-developer%2Fintellij-dependency-analytics%202022.1&type=code

@zvigrinberg
Copy link
Collaborator Author

zvigrinberg commented Aug 8, 2024

@xieshenzh Yes i know about to update the idea version ( the version needed to be changed in the workflow files accordingly to the newer version)..
The problem is that if we'll stay with 2022.3 , then clients with IJ IDEA version of >=2024.1.x, will have the error in https://issues.redhat.com/browse/TC-1718, to fix this error ( choose updating thread of BGT or EDT instead of OLD_EDT), you need to upgrade the IJ Version to 2024.1, and then accordingly to bump the versions of dockerfile and go plugins to be compatible with that IJ IDEA framework version.
And yes, probably dockerfile and go plugins will be affected.
I'll try to use version 2022.3, maybe the required api types and fields required for the fix are there... and the regression will be less dramatic and explosive, Thanks for the advice!.

fix: bug of component analysis not working because of deprecated OLD_ED

Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
@zvigrinberg zvigrinberg force-pushed the feature/support-idea-2024.1.x branch from 57f19dc to 12ddc66 Compare August 8, 2024 18:29
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
@xieshenzh
Copy link
Collaborator

We should also change the idea-version to <idea-version since-build="223"/>

<idea-version since-build="211.0"/>

Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
Copy link

sonarcloud bot commented Aug 9, 2024

@zvigrinberg zvigrinberg merged commit c0e71fc into main Aug 13, 2024
9 checks passed
@zvigrinberg zvigrinberg removed the hold label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants