Skip to content

Conversation

nmirasch
Copy link
Contributor

@nmirasch nmirasch commented Sep 4, 2025

cherry-pick of #949

  • Skip error log when console link is disabled and absent
  • Remove ConsoleLink when disabled, otherwise reconcile

(cherry picked from commit 9e522bf)

…developer#949)

* Skip error log when console link is disabled and absent

Signed-off-by: nmirasch <neus.miras@gmail.com>

* Remove ConsoleLink when disabled, otherwise reconcile

Signed-off-by: nmirasch <neus.miras@gmail.com>

---------

Signed-off-by: nmirasch <neus.miras@gmail.com>
(cherry picked from commit 9e522bf)
@openshift-ci openshift-ci bot requested review from jgwest and wtam2018 September 4, 2025 07:39
Copy link

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anandf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 4, 2025

Hi @nmirasch. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Member

svghadi commented Sep 4, 2025

/ok-to-test

Copy link

openshift-ci bot commented Sep 4, 2025

@nmirasch: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-parallel 7a59662 link true /test v4.14-kuttl-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants