Update the TLS termination of the default instance from passthrough to rencrypt #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chetan-rns
force-pushed
the
update-tls-termination
branch
3 times, most recently
from
6c96f41
to
02442bf
Compare
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
bdb2e0f
to
34ce297
Compare
chetan-rns
force-pushed
the
update-tls-termination
branch
from
34ce297
to
1fe9766
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
1fe9766
to
2196d1b
Compare
|
/retest |
1 similar comment
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
6ea391c
to
7c9c099
Compare
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
dd185d2
to
e5324e5
Compare
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
e5324e5
to
c2080ee
Compare
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
886a0d4
to
853cd29
Compare
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
c8ad670
to
452351e
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
4cafaa4
to
f10e0c6
Compare
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
chetan-rns
force-pushed
the
update-tls-termination
branch
from
f10e0c6
to
e55ae25
Compare
|
/retest |
chetan-rns
force-pushed
the
update-tls-termination
branch
from
e55ae25
to
460972c
Compare
jgwest
changed the title
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
chetan-rns
force-pushed
the
update-tls-termination
branch
from
460972c
to
4ae3309
Compare
/retest |
/retest |
|
@chetan-rns: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jgwest
approved these changes
May 24, 2024
trdoyle81
pushed a commit
to trdoyle81/gitops-operator
that referenced
this pull request
Aug 13, 2024
…o rencrypt (redhat-developer#703) * Update TLS termination from passthrough to reencrypt Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * add e2e tests to verify the default route Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * update the default TLS config in the argocd operator Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * revert the edge termination policy to Redirect Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * Fix e2e tests validate_default_argocd_route Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * Run e2e test in parallel Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * update argocd-operator to bring in TLS config changes Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * Add missing permissions to list networkpolicies Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> --------- Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-4674
Test acceptance criteria:
How to test changes / Special notes to the reviewer: