Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade argocd-operator-0.10 #685

Closed

Conversation

saumeya
Copy link
Member

@saumeya saumeya commented Apr 29, 2024

What type of PR is this?

/kind bug

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@openshift-ci openshift-ci bot requested review from ciiay and keithchong April 29, 2024 10:30
Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jannfis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saumeya saumeya requested review from iam-veeramalla and svghadi and removed request for keithchong and ciiay April 29, 2024 10:33
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the notification CRD to latest to include argoproj-labs/argocd-operator#1315

Please pull in the latest NotificationsConfiguration CRD changes to https://github.com/redhat-developer/gitops-operator/blob/v1.12/config/crd/bases/argoproj.io_notificationsconfigurations.yaml file

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@iam-veeramalla
Copy link
Collaborator

Duplicates #691

@svghadi svghadi closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants