Skip to content

downstream creating networkpolicies for argocd components. #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anandrkskd wants to merge 2 commits into
base: master
Choose a base branch
from
Open

downstream creating networkpolicies for argocd components. #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
768902b
downstream networkpolicy
anandrkskd Feb 25, 2026
8d8c644
add netwrok policy for principal component and add tests
anandrkskd Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 56 additions & 16 deletions bundle/manifests/argoproj.io_argocds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1900,6 +1900,18 @@ spec:
- name
type: object
type: array
networkPolicy:
description: NetworkPolicy controls whether the operator should create
NetworkPolicy resources for this Argo CD instance.
properties:
enabled:
default: true
description: |-
Enabled defines whether NetworkPolicy resources should be created for this Argo CD instance.
When enabled, the operator will reconcile NetworkPolicies for Argo CD components.
When disabled, the operator will remove any previously-created NetworkPolicies.
type: boolean
type: object
nodePlacement:
description: NodePlacement defines NodeSelectors and Taints for Argo
CD workloads
Expand Down Expand Up @@ -2221,15 +2233,20 @@ spec:
ArgoCD.
properties:
enabled:
description: Enabled will toggle Prometheus support globally for
ArgoCD.
description: |-
Enabled will toggle Prometheus support globally for ArgoCD.
When set to true, ServiceMonitors and PrometheusRules will be created for Argo CD metrics.
The Prometheus CR, Route, and Ingress are deprecated and will no longer be created.
type: boolean
host:
description: Host is the hostname to use for Ingress/Route resources.
description: |-
Host is the hostname to use for Ingress/Route resources.
Deprecated: This field is no longer used and will be ignored.
type: string
ingress:
description: Ingress defines the desired state for an Ingress
for the Prometheus component.
description: |-
Ingress defines the desired state for an Ingress for the Prometheus component.
Deprecated: This field is no longer used and will be ignored.
properties:
annotations:
additionalProperties:
Expand Down Expand Up @@ -2281,8 +2298,9 @@ spec:
- enabled
type: object
route:
description: Route defines the desired state for an OpenShift
Route for the Prometheus component.
description: |-
Route defines the desired state for an OpenShift Route for the Prometheus component.
Deprecated: This field is no longer used and will be ignored.
properties:
annotations:
additionalProperties:
Expand Down Expand Up @@ -2388,7 +2406,9 @@ spec:
- enabled
type: object
size:
description: Size is the replica count for the Prometheus StatefulSet.
description: |-
Size is the replica count for the Prometheus StatefulSet.
Deprecated: This field is no longer used and will be ignored.
format: int32
type: integer
required:
Expand Down Expand Up @@ -17981,6 +18001,18 @@ spec:
- name
type: object
type: array
networkPolicy:
description: NetworkPolicy controls whether the operator should create
NetworkPolicy resources for this Argo CD instance.
properties:
enabled:
default: true
description: |-
Enabled defines whether NetworkPolicy resources are created for this Argo CD instance.
When enabled, the operator will reconcile NetworkPolicies for Argo CD components.
When disabled, the operator will remove any previously-created NetworkPolicies.
type: boolean
type: object
nodePlacement:
description: NodePlacement defines NodeSelectors and Taints for Argo
CD workloads
Expand Down Expand Up @@ -18302,15 +18334,20 @@ spec:
ArgoCD.
properties:
enabled:
description: Enabled will toggle Prometheus support globally for
ArgoCD.
description: |-
Enabled will toggle Prometheus support globally for ArgoCD.
When set to true, ServiceMonitors and PrometheusRules will be created for Argo CD metrics.
The Prometheus CR, Route, and Ingress are deprecated and will no longer be created.
type: boolean
host:
description: Host is the hostname to use for Ingress/Route resources.
description: |-
Host is the hostname to use for Ingress/Route resources.
Deprecated: This field is no longer used and will be ignored.
type: string
ingress:
description: Ingress defines the desired state for an Ingress
for the Prometheus component.
description: |-
Ingress defines the desired state for an Ingress for the Prometheus component.
Deprecated: This field is no longer used and will be ignored.
properties:
annotations:
additionalProperties:
Expand Down Expand Up @@ -18362,8 +18399,9 @@ spec:
- enabled
type: object
route:
description: Route defines the desired state for an OpenShift
Route for the Prometheus component.
description: |-
Route defines the desired state for an OpenShift Route for the Prometheus component.
Deprecated: This field is no longer used and will be ignored.
properties:
annotations:
additionalProperties:
Expand Down Expand Up @@ -18469,7 +18507,9 @@ spec:
- enabled
type: object
size:
description: Size is the replica count for the Prometheus StatefulSet.
description: |-
Size is the replica count for the Prometheus StatefulSet.
Deprecated: This field is no longer used and will be ignored.
format: int32
type: integer
required:
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/gitops-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ metadata:
capabilities: Deep Insights
console.openshift.io/plugins: '["gitops-plugin"]'
containerImage: quay.io/redhat-developer/gitops-operator
createdAt: "2026-02-18T10:47:28Z"
createdAt: "2026-02-25T05:56:01Z"
description: Enables teams to adopt GitOps principles for managing cluster configurations
and application delivery across hybrid multi-cluster Kubernetes environments.
features.operators.openshift.io/disconnected: "true"
Expand Down
72 changes: 56 additions & 16 deletions config/crd/bases/argoproj.io_argocds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1889,6 +1889,18 @@ spec:
- name
type: object
type: array
networkPolicy:
description: NetworkPolicy controls whether the operator should create
NetworkPolicy resources for this Argo CD instance.
properties:
enabled:
default: true
description: |-
Enabled defines whether NetworkPolicy resources should be created for this Argo CD instance.
When enabled, the operator will reconcile NetworkPolicies for Argo CD components.
When disabled, the operator will remove any previously-created NetworkPolicies.
type: boolean
type: object
nodePlacement:
description: NodePlacement defines NodeSelectors and Taints for Argo
CD workloads
Expand Down Expand Up @@ -2210,15 +2222,20 @@ spec:
ArgoCD.
properties:
enabled:
description: Enabled will toggle Prometheus support globally for
ArgoCD.
description: |-
Enabled will toggle Prometheus support globally for ArgoCD.
When set to true, ServiceMonitors and PrometheusRules will be created for Argo CD metrics.
The Prometheus CR, Route, and Ingress are deprecated and will no longer be created.
type: boolean
host:
description: Host is the hostname to use for Ingress/Route resources.
description: |-
Host is the hostname to use for Ingress/Route resources.
Deprecated: This field is no longer used and will be ignored.
type: string
ingress:
description: Ingress defines the desired state for an Ingress
for the Prometheus component.
description: |-
Ingress defines the desired state for an Ingress for the Prometheus component.
Deprecated: This field is no longer used and will be ignored.
properties:
annotations:
additionalProperties:
Expand Down Expand Up @@ -2270,8 +2287,9 @@ spec:
- enabled
type: object
route:
description: Route defines the desired state for an OpenShift
Route for the Prometheus component.
description: |-
Route defines the desired state for an OpenShift Route for the Prometheus component.
Deprecated: This field is no longer used and will be ignored.
properties:
annotations:
additionalProperties:
Expand Down Expand Up @@ -2377,7 +2395,9 @@ spec:
- enabled
type: object
size:
description: Size is the replica count for the Prometheus StatefulSet.
description: |-
Size is the replica count for the Prometheus StatefulSet.
Deprecated: This field is no longer used and will be ignored.
format: int32
type: integer
required:
Expand Down Expand Up @@ -17970,6 +17990,18 @@ spec:
- name
type: object
type: array
networkPolicy:
description: NetworkPolicy controls whether the operator should create
NetworkPolicy resources for this Argo CD instance.
properties:
enabled:
default: true
description: |-
Enabled defines whether NetworkPolicy resources are created for this Argo CD instance.
When enabled, the operator will reconcile NetworkPolicies for Argo CD components.
When disabled, the operator will remove any previously-created NetworkPolicies.
type: boolean
type: object
nodePlacement:
description: NodePlacement defines NodeSelectors and Taints for Argo
CD workloads
Expand Down Expand Up @@ -18291,15 +18323,20 @@ spec:
ArgoCD.
properties:
enabled:
description: Enabled will toggle Prometheus support globally for
ArgoCD.
description: |-
Enabled will toggle Prometheus support globally for ArgoCD.
When set to true, ServiceMonitors and PrometheusRules will be created for Argo CD metrics.
The Prometheus CR, Route, and Ingress are deprecated and will no longer be created.
type: boolean
host:
description: Host is the hostname to use for Ingress/Route resources.
description: |-
Host is the hostname to use for Ingress/Route resources.
Deprecated: This field is no longer used and will be ignored.
type: string
ingress:
description: Ingress defines the desired state for an Ingress
for the Prometheus component.
description: |-
Ingress defines the desired state for an Ingress for the Prometheus component.
Deprecated: This field is no longer used and will be ignored.
properties:
annotations:
additionalProperties:
Expand Down Expand Up @@ -18351,8 +18388,9 @@ spec:
- enabled
type: object
route:
description: Route defines the desired state for an OpenShift
Route for the Prometheus component.
description: |-
Route defines the desired state for an OpenShift Route for the Prometheus component.
Deprecated: This field is no longer used and will be ignored.
properties:
annotations:
additionalProperties:
Expand Down Expand Up @@ -18458,7 +18496,9 @@ spec:
- enabled
type: object
size:
description: Size is the replica count for the Prometheus StatefulSet.
description: |-
Size is the replica count for the Prometheus StatefulSet.
Deprecated: This field is no longer used and will be ignored.
format: int32
type: integer
required:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.25.5

require (
github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260218104514-432c01ce417a
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225073619-a52ee52d3941
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225142026-dabb25d60d94
github.com/argoproj/argo-cd/v3 v3.3.0
github.com/argoproj/gitops-engine v0.7.1-0.20251217140045-5baed5604d2d
github.com/go-logr/logr v1.4.3
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260218104514-432c01ce4
github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260218104514-432c01ce417a/go.mod h1:WPyZkNHZjir/OTt8mrRwcUZKe1euHrHPJsRv1Wp/F/0=
github.com/argoproj-labs/argocd-image-updater v1.1.1 h1:7YDaR3WX2NMsDKp0wN7TRaRRHaVHQ94tSybi2P99MGk=
github.com/argoproj-labs/argocd-image-updater v1.1.1/go.mod h1:gMHiNrGNwNSt4ljf0ykcnmNvXBk/NJ+Z17AnZVe7V7I=
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225073619-a52ee52d3941 h1:wkBZFBhSxIpaOfQOwQT44kgwkI/UC7IxM85GJ8w+nHI=
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225073619-a52ee52d3941/go.mod h1:3/Y9YWMU+DHC+onOQVXPAxrNkoBAGZD+UQui9BgJBjY=
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225142026-dabb25d60d94 h1:1HO3tG4kb0rJ2XD+pjHlSLbZMufBl/fNqGhkf9vkpho=
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225142026-dabb25d60d94/go.mod h1:3/Y9YWMU+DHC+onOQVXPAxrNkoBAGZD+UQui9BgJBjY=
github.com/argoproj/argo-cd/v3 v3.3.0 h1:9UlruTd5cC/MyvorTXgAIblfZTy63MF5FYvvoAaUvwU=
github.com/argoproj/argo-cd/v3 v3.3.0/go.mod h1:5VAfe0s/a4VY5GmAIFK76FtW6xn7zAcLmaw25bOL/2g=
github.com/argoproj/gitops-engine v0.7.1-0.20251217140045-5baed5604d2d h1:iUJYrbSvpV9n8vyl1sBt1GceM60HhHfnHxuzcm5apDg=
Expand Down
5 changes: 5 additions & 0 deletions test/openshift/e2e/ginkgo/fixture/agent/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
routev1 "github.com/openshift/api/route/v1"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
networkingv1 "k8s.io/api/networking/v1"
rbacv1 "k8s.io/api/rbac/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
Expand All @@ -47,6 +48,7 @@ type PrincipalResources struct {
ClusterRoleBinding *rbacv1.ClusterRoleBinding
PrincipalDeployment *appsv1.Deployment
PrincipalRoute *routev1.Route
PrincipalNetworkPolicy *networkingv1.NetworkPolicy
ServicesToDelete []string
}

Expand Down Expand Up @@ -102,6 +104,7 @@ type VerifyExpectedResourcesExistParams struct {
ClusterRoleBinding *rbacv1.ClusterRoleBinding
PrincipalDeployment *appsv1.Deployment
PrincipalRoute *routev1.Route
PrincipalNetworkPolicy *networkingv1.NetworkPolicy
SecretNames AgentSecretNames
ServiceNames []string
DeploymentNames []string
Expand All @@ -118,6 +121,7 @@ func VerifyResourcesDeleted(resources PrincipalResources) {
Eventually(resources.ClusterRole).Should(k8sFixture.NotExistByName())
Eventually(resources.ClusterRoleBinding).Should(k8sFixture.NotExistByName())
Eventually(resources.PrincipalDeployment).Should(k8sFixture.NotExistByName())
Eventually(resources.PrincipalNetworkPolicy).Should(k8sFixture.NotExistByName())

for _, serviceName := range resources.ServicesToDelete {
if serviceName == "" {
Expand Down Expand Up @@ -327,6 +331,7 @@ func VerifyExpectedResourcesExist(params VerifyExpectedResourcesExistParams) {
Eventually(params.RoleBinding).Should(k8sFixture.ExistByName())
Eventually(params.ClusterRole).Should(k8sFixture.ExistByName())
Eventually(params.ClusterRoleBinding).Should(k8sFixture.ExistByName())
Eventually(params.PrincipalNetworkPolicy).Should(k8sFixture.ExistByName())

for _, serviceName := range params.ServiceNames {
if serviceName == "" {
Expand Down
Loading