Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix build of devspaces-code #577

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

RomanNikitenko
Copy link
Contributor

Issue: https://issues.redhat.com/browse/CRW-6313

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the potential downsides of applying this flag.
Anyway, if it will make the Brew build green - it's a good workaround 🙂
Let's try it - I'm merging the PR.

@azatsarynnyy azatsarynnyy merged commit 61ab09b into devspaces-3-rhel-8 May 22, 2024
@azatsarynnyy azatsarynnyy deleted the fix-code-build branch May 22, 2024 10:00
@RomanNikitenko
Copy link
Contributor Author

I don't think there is a downside:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants