Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: removed mention of "hybrid" or "dedicated" clusters #1838

Merged
merged 2 commits into from
Mar 21, 2023
Merged

docs: removed mention of "hybrid" or "dedicated" clusters #1838

merged 2 commits into from
Mar 21, 2023

Conversation

jackdelahunt
Copy link
Contributor

@jackdelahunt jackdelahunt commented Mar 21, 2023 •
edited
Loading

Clusters used in RHOSAK are now referred to as just Openshift Clusters instead of the old dedicated or hybrid.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@jackdelahunt jackdelahunt requested a review from dimakis March 21, 2023 10:47
dimakis
dimakis requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenShift Cluster here please:

line 1200 of kafka.en.toml, I do not know why GH won't allow me to comment on the exact line 😠

@jackdelahunt
Copy link
Contributor Author

OpenShift Cluster here please

Done

@dimakis
Copy link
Contributor

dimakis commented Mar 21, 2023

Lgtm 😁

@jackdelahunt jackdelahunt merged commit bd4ce19 into main Mar 21, 2023
@jackdelahunt jackdelahunt deleted the remove-hybrid-docs branch March 21, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimakis dimakis dimakis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdelahunt @dimakis