-
Notifications
You must be signed in to change notification settings - Fork 61
Replace SELinux community module with LSR #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| minor_changes: | ||
| - Replace SELinux community module with Linux System Role. | ||
| ... |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,9 +9,11 @@ | |
| # failed_when: ausearch_results.stdout != "<no matches>" | ||
|
|
||
| - name: leapp-post-upgrade-selinux | SELinux mode is set to {{ selinux_mode }} | ||
| ansible.posix.selinux: | ||
| policy: targeted | ||
| state: "{{ selinux_mode }}" | ||
| ansible.builtin.include_role: | ||
| name: fedora.linux_system_roles.selinux | ||
| vars: | ||
| selinux_policy: targeted | ||
| selinux_state: "{{ selinux_mode }}" | ||
| register: selinux_results | ||
|
|
||
| - name: leapp-post-upgrade-selinux | Reboot when required for SELinux change | ||
|
|
@@ -22,9 +24,11 @@ | |
| when: selinux_results.reboot_required | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does selinux role return a reboot_required variable? That might not be applicable to the role.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes you are right, according the documentation it should be |
||
|
|
||
| - name: leapp-post-upgrade-selinux | Verify SELinux is set to {{ selinux_mode }} | ||
| ansible.posix.selinux: | ||
| policy: targeted | ||
| state: "{{ selinux_mode }}" | ||
| ansible.builtin.include_role: | ||
| name: fedora.linux_system_roles.selinux | ||
| vars: | ||
| selinux_policy: targeted | ||
| selinux_state: "{{ selinux_mode }}" | ||
| check_mode: true | ||
| register: selinux_check_results | ||
| failed_when: selinux_check_results.changed | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. include_role might not return
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct. It does not return
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in fact - you cannot use |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registerdoes not work withinclude_roleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I have now realised that now its for
include_role