Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible Tower: Update manage-inventories #636

Merged
merged 4 commits into from
Aug 12, 2021

Conversation

MAHDTech
Copy link
Contributor

@MAHDTech MAHDTech commented Aug 6, 2021

What does this PR do?

Role: ansible-tower/manage-inventories

  • Move the get inventories call to outside the loop
  • Use return value to capture any new inventory id
  • Allow updating existing inventory with changes

How should this be tested?

Execute role against Ansible Tower instance with and without inventories.

Is there a relevant Issue open for this?

No

Other Relevant info, PRs, etc.

People to notify

cc: @redhat-cop/infra-ansible

- Move the get inventories call to outside the loop
- Use return value to capture any new inventory id
@MAHDTech MAHDTech changed the title Ansible Tower: Utilize return values Ansible Tower: Update manage-inventories Aug 6, 2021
@MAHDTech MAHDTech marked this pull request as ready for review August 6, 2021 04:23
oybed
oybed previously approved these changes Aug 12, 2021
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lint fixes
Lint fixes
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oybed oybed merged commit adf84a7 into redhat-cop:main Aug 12, 2021
@MAHDTech MAHDTech mentioned this pull request Sep 1, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants