Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait after LDAP Secret Patch for rollout to complete #598

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

paulbarfuss
Copy link
Contributor

What does this PR do?

This will confirm the rollout has been successful to help avoid a race condition when fetching organizations during the manage-credential or similar phases of the deployment when it expects an org_id from your LDAP provider.

How should this be tested?

Needs a full end-2-end deployment on Openshfit with LDAP configuration and dependent organizations to see the bug and verify it is fixed.

Is there a relevant Issue open for this?

Provide a link to any open issues that describe the problem you are solving.
resolves #

Other Relevant info, PRs, etc.

Please provide link to other PRs that may be related (blocking, resolves, etc. etc.)

People to notify

cc: @redhat-cop/infra-ansible

@paulbarfuss paulbarfuss changed the title Draft: Add wait after LDAP Secret Patch for rollout to complete Add wait after LDAP Secret Patch for rollout to complete Mar 31, 2021
@paulbarfuss
Copy link
Contributor Author

Tested on our sandbox and confirmed the deployment completes in about 10-20 seconds after which the subsequent configurations are working with LDAP.

@paulbarfuss paulbarfuss requested a review from oybed March 31, 2021 18:44
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oybed oybed merged commit 1de4b02 into redhat-cop:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants