Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PVC storage for containerized Ansible Tower running on OCP #590
Support PVC storage for containerized Ansible Tower running on OCP #590
Changes from 1 commit
2a4560b
fad2a09
fffcd15
8b8b80d
b6c394f
abcf48e
58674d3
b82169f
60e13db
50ab8d2
20a1428
c951694
0cf2f93
674dfae
1ac32a3
1e31ee5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is already performed in the
openshift_retrieve_token
, so shouldn't be needed here - probably just remove this task(?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved the authentication part to a separate file, but in the case that only OCP token is provided we need to have a step for login. openshift_retrieve_token was only used when username and password was provided, it did not cover the token based authentication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a left-over, but there's one
oc get project
above and twooc new-project
here - seems a bit redundant + not sure what this task actually does as it registersgetProject
over again.Another couple of comments:
setup_pvc
as that's a bit "hidden". Better idea would be to do so in themain.yml
or a separate file for creating the projectThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that was overlooked and it has been fixed, I've also changed the file structure to be a bit more clean and self-explanatory. I will also look into handling the the condition in which project has already been created by other user.