Skip to content

Conversation

@etsauer
Copy link
Collaborator

@etsauer etsauer commented Jun 18, 2019

Copy link
Collaborator

@mathianasj mathianasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you split up the roles so that it restricts what it needs to run the operator in the namespace the container is running and what it needs to perform its tasks against routes and secrets

- watch
- create
- update
- apiGroups:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to include this one so it can update existing routes

- apiGroups:
  - "route.openshift.io"
  resources:
  - routes/custom-host
  verbs:
  - update

metadata:
name: cert-operator-local
rules:
- apiGroups:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and these

  - apiGroups:
    - extensions
    resources:
    - replicasets
    - deployments
    verbs:
    - "get"
  - apiGroups:
    - monitoring.coreos.com
    resources:
    - servicemonitors
    verbs:
    - "get"
    - "create"
  - apiGroups:
    - extensions
    resources:
    - deployments/finalizers
    resourceNames:
    - cert-operator
    verbs:
    - "update"

@etsauer
Copy link
Collaborator Author

etsauer commented Jul 9, 2019

@mathianasj made the recommended changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants