DEVAI-147: Define catalog structure for model catalogs in RHDH#2
Merged
johnmcollier merged 8 commits intomainfrom Sep 25, 2024
Merged
DEVAI-147: Define catalog structure for model catalogs in RHDH#2johnmcollier merged 8 commits intomainfrom
johnmcollier merged 8 commits intomainfrom
Conversation
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Jdubrick
reviewed
Sep 24, 2024
Contributor
Jdubrick
left a comment
Jdubrick
left a comment
There was a problem hiding this comment.
Just a couple small comments! Overall I like the bulk of the content and think this is good
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Co-authored-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
Contributor
Author
|
@Jdubrick Review comments addressed if you don't mind re-reviewing when you have time, thanks! |
Co-authored-by: Jordan Dubrick <jdubrick@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the model-catalog readme to include the model catalog structure, that was previously documented in https://docs.google.com/document/d/1ArB8w-TawZ_DuMbZoukk4inVsAgqHntB8yN2lttwjyo/edit?usp=sharing.
The readme includes a table outlining the metadata for the model servers and models that are stored in the catalog