Conversation
gabemontero
left a comment
gabemontero
left a comment
There was a problem hiding this comment.
One question to try and better understand the details of your workaround here @thepetk
| - package: ./dynamic-plugins/dist/backstage-community-plugin-catalog-backend-module-keycloak-dynamic | ||
| disabled: false | ||
| - package: ./dynamic-plugins/dist/backstage-community-plugin-redhat-argocd | ||
| - package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-redhat-argocd:bs_1.42.5__2.0.0!backstage-community-plugin-redhat-argocd |
There was a problem hiding this comment.
can you clarify @thepetk if the ./dynamic-plugins/dist/... version is a later version of this package, or an older version from what you get from the oci image ?
There was a problem hiding this comment.
Generally the OCI archive should be newer, but I'll wait for Fanis to confirm, since I know RHDH had kept some plugins in the old format
There was a problem hiding this comment.
@gabemontero @johnmcollier that's my guess too. I'll follow up with details tomorrow. I've also noticed there might be an alternative way. For sure this one works.
There was a problem hiding this comment.
So I did a second investigation:
- Most of wrappers have been removed in 1.9 (see RHIDP-10846). That said the usage of the oci package directly is required.
- Now I'm testing two things based on Gabe's comment.
- I see there's another -> newer/renamed version of the package here (see RHIDP-11335). I'm currently testing it.
- I think this is the right time to replace the backend argocd (from roadie) plugin with our community one
I'll follow up once I have completed my tests
Note a very interesting link to see all changes is here: https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/1692/changes
There was a problem hiding this comment.
yeah use of oci images does seem to be the "strategic direction" .... the doc ref you posted @thepetk does resonate with things I know remember hearing in various RHDH calls
over time do we think we want to migrate as many of the dynamic plugins as we can to oci refs @thepetk @johnmcollier ?
There was a problem hiding this comment.
yup +1 @gabemontero I was going to create a dedicated issue for 1.10 after my investigation is completed (also to clean maybe a bit our configuration).
johnmcollier
left a comment
johnmcollier
left a comment
There was a problem hiding this comment.
LGTM, but I'd wait til you confirm if the Argo OCI plugin is newest
thepetk
force-pushed
the
bump-up-rhdh-1-9
branch
from
00e00af to
cbd49e4
Compare
|
Switching back to draft so we can also include the changes mentioned here: #77 (comment) |
|
@gabemontero @johnmcollier closing in favor of #78 which also bumps the RHDH Chart version PTAL |
3 participants
What does this PR do?
Bumps again RHDH to 1.9 -> using the
1.9-172tag. As the 1.9 was complaining for./dynamic-plugins/dist/backstage-community-plugin-redhat-argocdI had to switch to the overlays version.Which issue(s) does this PR fix
fixes RHDHBUGS-2502
How to test changes / Special notes to the reviewer
I preformed test deployment based on the same deployment scenario: