Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace string feature with symbol #109

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Replace string feature with symbol #109

merged 1 commit into from
Apr 17, 2020

Conversation

hlissner
Copy link
Contributor

This is a minor optimization.

(eval-after-load FILE FORM)

When FILE is a string, eval-after-load will scan the path of every file that is loaded for a match for FILE, and will do so even after evil has been loaded.

When FILE is a symbol, you avoid this polling behavior. Instead, Emacs waits for a (provide 'FILE) to evaluate FORM, which is marginally more performant.

@redguardtoo redguardtoo merged commit 747e346 into redguardtoo:master Apr 17, 2020
@redguardtoo
Copy link
Owner

Thanks

redguardtoo pushed a commit to redguardtoo/emacs.d that referenced this pull request Apr 17, 2020
hlissner added a commit to doomemacs/doomemacs that referenced this pull request Apr 17, 2020
daveduthie pushed a commit to daveduthie/doom-emacs that referenced this pull request Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants