Skip to content

Commit

Permalink
Complete Spanish translations #10
Browse files Browse the repository at this point in the history
Text on the "thank you" and "sorry" pages is now the same in English,
and therefore also in Spanish (see #123). Title tags in the document
head are also translated. This update also contains some changes to the
Enlish locale json file that reflect that all translated strings have
now been invoked in English as well as Spanish (e.g., adding __() around
the "invalid zip code error" and then viewing that error with locale set
to Spanish will add the error text to "es.js", but nothing will happen
to "en.js" until the error is viewed with locale set to English).

Adding the "language switcher" to the UI and using it to set a
locale-specific cookie on the user's browser still remains to be done.
  • Loading branch information
nttaylor committed Oct 23, 2015
1 parent 71b2933 commit 668b46b
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 11 deletions.
38 changes: 31 additions & 7 deletions locales/en.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion locales/es.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion views/layout.jade
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ html(lang='en')
meta(http-equiv='Content-Type', content='text/html; charset=UTF-8')
meta(charset='utf-8')
meta(http-equiv='X-UA-Compatible', content='IE=10; IE=9; IE=8; IE=EDGE')
title Get a Smoke Alarm
title #{__('Get a Smoke Alarm')}
meta(name='description', content='Get a Smoke Alarm from the Red Cross.')
meta#id_og_type(property='og:type', content='website')
meta#id_og_title(property='og:title', content='Get a Smoke Alarm')
Expand Down
2 changes: 1 addition & 1 deletion views/sorry.jade
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ block content
#container
.row
.col-sm-12
h1 American Red Cross of Chicago & Northern Illinois
h1 #{__('American Red Cross')}
if county
p
| #{__('Sorry, the Red Cross Region serving %s County, %s does not yet offer smoke alarm installation service.', county, state)} #{__('However, we will remember your request and contact you when smoke alarm installation service is available in your region.')} #{__('Thank you for contacting the Red Cross.')}
Expand Down
2 changes: 1 addition & 1 deletion views/thankyou.jade
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ block content
#container.container-fluid
.row
.col-sm-12
h1 American Red Cross
h1 #{__('American Red Cross')}
#main.row
#left.col-sm-10
p
Expand Down

0 comments on commit 668b46b

Please sign in to comment.