Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Module support - packr compilation script. #3

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Go Module support - packr compilation script. #3

merged 4 commits into from
Jul 9, 2020

Conversation

gallypette
Copy link
Contributor

Hi,

This PR proposes some minor changes to you project as I had some issues with it (the binary distributed in 003e024 does not embed ./templates and is linked to you home folder):

  • removes the said binary (you may prefer to put that in a release)
  • moves to go.mod / go.sum
  • compile.sh compiles releases for osx, linux and windows that actually embed ./templates inside the binary.

cheers,
jlouis

@gallypette gallypette changed the title Go Module supprot Go Module support - packr compilation script. Jul 7, 2020
@wintrmvte wintrmvte merged commit c975a13 into redcode-labs:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gallypette @wintrmvte