Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on T1098.md #2993

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Fix typo on T1098.md #2993

merged 6 commits into from
Dec 11, 2024

Conversation

za
Copy link
Contributor

@za za commented Nov 22, 2024

Nothing fancy: just fixing a typo.

Copy link
Collaborator

@clr2of8 clr2of8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the md files are auto-generated from the yaml files of the same, could you update the yaml file instead? Thank you

@za
Copy link
Contributor Author

za commented Dec 11, 2024

Noted 📝

@za
Copy link
Contributor Author

za commented Dec 11, 2024

Hi @clr2of8 kindly check, I've updated the yaml file.

Copy link
Collaborator

@clr2of8 clr2of8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I should have been a little more specific. The only file that needs the update is the https://github.com/redcanaryco/atomic-red-team/blob/master/atomics/T1098/T1098.yaml file. The yaml Indexes and the mark downs (md) will all be updated automatically. There are some additional notes about it here

@za
Copy link
Contributor Author

za commented Dec 11, 2024

I'm sorry, I should have been a little more specific. The only file that needs the update is the https://github.com/redcanaryco/atomic-red-team/blob/master/atomics/T1098/T1098.yaml file. The yaml Indexes and the mark downs (md) will all be updated automatically. There are some additional notes about it here

Ah, sorry. I miss reading the Contributing notes there.

I've updated the T1098.yaml file. Should I revert changes on the other files? @clr2of8

@za
Copy link
Contributor Author

za commented Dec 11, 2024

Probably, I'll just create a new PR...

Copy link
Collaborator

@clr2of8 clr2of8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for your first-time contribution. Keep it up! Don't forget to claim your free Atomic Red Team t-shirt

No need to worry about revoking the other changes as those files will get automatically overwritten

@clr2of8 clr2of8 merged commit 6cb8a46 into redcanaryco:master Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants