Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: removed the "status" flag requirements for displaying error messages from the catch block. #2599

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

shilob
Copy link
Member

@shilob shilob commented Nov 11, 2024

Currently the status flag is checked before displaying a critical error. This is unnecessary.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.15%. Comparing base (1a62078) to head (6621458).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2599   +/-   ##
========================================
  Coverage    53.15%   53.15%           
========================================
  Files          179      179           
  Lines         9420     9420           
  Branches      1359     1359           
========================================
  Hits          5007     5007           
  Misses        4189     4189           
  Partials       224      224           
Flag Coverage Δ
backend-bruno 44.68% <ø> (ø)
backend-mocha 49.46% <ø> (ø)
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 53.78% <ø> (ø)
frontend-dashboard 74.53% <ø> (ø)
frontend-deleted-records 86.59% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shilob shilob merged commit 3bcaa87 into develop Nov 11, 2024
7 checks passed
@shilob shilob deleted the bugfix/dmp-loading-error branch November 11, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants