Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to add on transition workflow trigger #2485

Merged
merged 12 commits into from
Oct 8, 2024

Conversation

alejandro-bulgaris-qcif
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 10.59603% with 135 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (3dce9d3) to head (4016baa).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
typescript/api/services/TriggerService.ts 0.00% 84 Missing ⚠️
typescript/api/controllers/RecordController.ts 15.90% 35 Missing and 2 partials ⚠️
typescript/api/services/RecordsService.ts 40.00% 12 Missing ⚠️
...ipt/api/controllers/webservice/RecordController.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2485      +/-   ##
===========================================
- Coverage    53.49%   52.79%   -0.70%     
===========================================
  Files          178      178              
  Lines         9184     9300     +116     
  Branches      1319     1343      +24     
===========================================
- Hits          4913     4910       -3     
- Misses        4055     4172     +117     
- Partials       216      218       +2     
Flag Coverage Δ
backend-bruno 44.19% <10.59%> (-0.73%) ⬇️
backend-mocha 48.97% <10.59%> (-0.80%) ⬇️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 53.78% <ø> (ø)
frontend-dashboard 74.53% <ø> (ø)
frontend-deleted-records 86.59% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}


public setWorkflowStepInMetaMetadata(currentRec: any, nextStep: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit nit-picky but can i suggest this method be renamed setWorkflowStepRelatedMetadata?
Its a bit of a mouthful but its more accurate than the current name as we set workflow and previousWorkflow as well as metaMetadata

@andrewbrazzatti andrewbrazzatti merged commit 605a8e9 into develop Oct 8, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants