Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runtemplates performance #2421

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

andrewbrazzatti
Copy link
Contributor

The runTemplates trigger was compiling the templates each execution resulting in performance issues. This change allows for the templates to be compiled only once.

@andrewbrazzatti andrewbrazzatti merged commit f1cf3af into develop Sep 11, 2024
3 of 4 checks passed
@andrewbrazzatti andrewbrazzatti deleted the feature/improve-runtemplates-performance branch September 11, 2024 01:24
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 30.95238% with 29 lines in your changes missing coverage. Please review.

Project coverage is 57.35%. Comparing base (9ffe4bf) to head (bb76e84).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
typescript/api/services/RDMPService.ts 30.95% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2421      +/-   ##
===========================================
+ Coverage    53.65%   57.35%   +3.70%     
===========================================
  Files          176      176              
  Lines         8863     8869       +6     
  Branches      1260     1262       +2     
===========================================
+ Hits          4755     5087     +332     
+ Misses        3893     3773     -120     
+ Partials       215        9     -206     
Flag Coverage Δ
backend-bruno 49.61% <28.57%> (+4.18%) ⬆️
backend-mocha 54.78% <30.95%> (+4.45%) ⬆️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 52.41% <ø> (ø)
frontend-dashboard 79.31% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant