Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve authorized domains and email exceptions config #2357

Merged
merged 12 commits into from
Aug 26, 2024

Conversation

cofiem
Copy link
Contributor

@cofiem cofiem commented Aug 21, 2024

  • extract authorized email check to new method in UsersService
  • add mocha tests for the authorized email config
  • add bruno tests for a denied email and allowed email
  • add authorized domain / email check to oidc
  • implement authorized aaf and oidc domains and emails using branding aware functionality
  • improve reliability of tests using docker service halthchecks (particularly keycloak service)

@cofiem cofiem changed the title Improve authorized domains and email exceptions confguration Improve authorized domains and email exceptions config Aug 21, 2024
@cofiem cofiem self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 79.51807% with 17 lines in your changes missing coverage. Please review.

Project coverage is 53.65%. Comparing base (64a5eb2) to head (e6fe44f).
Report is 1 commits behind head on develop.

Files Patch % Lines
typescript/api/services/UsersService.ts 78.72% 5 Missing and 5 partials ⚠️
typescript/api/controllers/UserController.ts 37.50% 4 Missing and 1 partial ⚠️
...script/api/configmodels/AuthorizedDomainsEmails.ts 87.50% 1 Missing ⚠️
typescript/api/services/AppConfigService.ts 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2357      +/-   ##
===========================================
+ Coverage    53.31%   53.65%   +0.33%     
===========================================
  Files          175      176       +1     
  Lines         8816     8863      +47     
  Branches      1243     1260      +17     
===========================================
+ Hits          4700     4755      +55     
+ Misses        3908     3893      -15     
- Partials       208      215       +7     
Flag Coverage Δ
backend-bruno 45.42% <56.62%> (+0.24%) ⬆️
backend-mocha 50.33% <79.51%> (+0.42%) ⬆️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 52.41% <ø> (ø)
frontend-dashboard 79.31% <ø> (ø)
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cofiem added 3 commits August 22, 2024 10:05
Includes an unauthorized user and a user allowed access via the email exceptions.
Updated keycloak database with two additional users.
@cofiem cofiem marked this pull request as ready for review August 26, 2024 00:17
@andrewbrazzatti andrewbrazzatti merged commit c898bc6 into develop Aug 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants