-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve authorized domains and email exceptions config #2357
Merged
andrewbrazzatti
merged 12 commits into
develop
from
feature/add-config-oidc-authorized-email
Aug 26, 2024
Merged
Improve authorized domains and email exceptions config #2357
andrewbrazzatti
merged 12 commits into
develop
from
feature/add-config-oidc-authorized-email
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cofiem
commented
Aug 21, 2024
•
edited
Loading
edited
- extract authorized email check to new method in UsersService
- add mocha tests for the authorized email config
- add bruno tests for a denied email and allowed email
- add authorized domain / email check to oidc
- implement authorized aaf and oidc domains and emails using branding aware functionality
- improve reliability of tests using docker service halthchecks (particularly keycloak service)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2357 +/- ##
===========================================
+ Coverage 53.31% 53.65% +0.33%
===========================================
Files 175 176 +1
Lines 8816 8863 +47
Branches 1243 1260 +17
===========================================
+ Hits 4700 4755 +55
+ Misses 3908 3893 -15
- Partials 208 215 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Includes an unauthorized user and a user allowed access via the email exceptions. Updated keycloak database with two additional users.
cofiem
commented
Aug 22, 2024
cofiem
commented
Aug 22, 2024
cofiem
commented
Aug 22, 2024
…ware functionality Add link to config page on admin home page.
Provides self-service for authorized domains and emails. Fix 403 page as it is used when unauthorized email tries to login.
Tidy up docker compose files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.