Improve MQTT_STD_XXX behavior #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n MQTT_STD_XXX option is set. fix: Do not assume that std::string_view is constructable from a pair of iterators because that requires C++20. fix: Correctly check for std::make_shared<T[]> support
…in is a fancy iterator. It was also incorrectly calculating the size of the string_view
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
==========================================
- Coverage 83.08% 83.06% -0.02%
==========================================
Files 64 65 +1
Lines 10357 10358 +1
==========================================
- Hits 8605 8604 -1
- Misses 1752 1754 +2 |
…ke a pair of iterators
redboltz
reviewed
Apr 9, 2022
| @@ -358,7 +358,7 @@ class retained_topic_map { | |||
| void dump(Output &out) { | |||
| auto const& direct_index = map.template get<direct_index_tag>(); | |||
| for (auto const& i : direct_index) { | |||
| out << i.parent_id << " " << i.name << " " << (i.value ? "init" : "-") << " " << i.count << std::endl; | |||
| out << i.parent_id << " " << i.name << " " << (i.value ? "init" : "-") << " " << i.count << '\n'; | |||
There was a problem hiding this comment.
Why this replacement is needed ? Just avoid include ostream ?
There was a problem hiding this comment.
Correct, seeing that this is the only use of ostream in this file and this function is a debug function.
|
Thanks you for update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
std::make_shared<T[]>. See https://en.cppreference.com/w/cpp/feature_testretained_topic_map.hppjust to get access tostd::endl, use'\n'instead.Why
Including headers that are not used unnecessarily increases compile times. It is considered good practice to include only what you use.
Enabling the MQTT_STD_XXX options should not assume presence of full C++20 support, otherwise a user's application might not compile even if they are using C++17 with access to such std types.