Skip to content

Fixed azure build pipelines. #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Fixed azure build pipelines. #718

merged 2 commits into from
Nov 7, 2020

Conversation

redboltz
Copy link
Owner

@redboltz redboltz commented Nov 7, 2020

No description provided.

@redboltz redboltz force-pushed the fix_abp branch 3 times, most recently from 44954a4 to 971dd64 Compare November 7, 2020 05:39
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #718 (3234099) into master (8ce2aa6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
- Coverage   82.07%   82.06%   -0.02%     
==========================================
  Files          47       47              
  Lines        7087     7082       -5     
==========================================
- Hits         5817     5812       -5     
  Misses       1270     1270              

Windows returns unpredictable error codes depends on environment.
It is not meaningful checking error codes.
If close is requested, then simply call on_close, otherwiser call
on_error.
User can check error codes.
@redboltz
Copy link
Owner Author

redboltz commented Nov 7, 2020

Finally, azure build pipeline works well.
CI for MSVC is back.

It was tough work.

@redboltz redboltz merged commit ca47db0 into master Nov 7, 2020
@redboltz redboltz deleted the fix_abp branch November 7, 2020 12:32
@kleunen
Copy link
Contributor

kleunen commented Nov 7, 2020

well done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants