Added subscription_map tests. #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests forcused on using it on the broker.
Contributor
|
@redboltz To build the unit test with MSVC with boost dynamic linkage, i need to define BOOST_TEST_SOURCE to be able to compile the tests. They do say that 'this is a hack': http://boost.2283326.n4.nabble.com/Boost-unit-test-cpp-problem-when-try-to-compile-simple-program-td2596687.html // Copyright Takatoshi Kondo 2015
//
// Distributed under the Boost Software License, Version 1.0.
// (See accompanying file LICENSE_1_0.txt or copy at
// http://www.boost.org/LICENSE_1_0.txt)
#if !defined(MQTT_TEST_MAIN_HPP)
#define MQTT_TEST_MAIN_HPP
#define BOOST_TEST_SOURCE
#define BOOST_TEST_MODULE mqtt_client_cpp_test
#include <boost/test/unit_test.hpp>
#endif // MQTT_TEST_MAIN_HPP |
It always inserts.
Owner
Author
Now #687 is unstable. Several hours ago , the Linux CI failure is caused by environmental issue. It seems that the issue is fixed by github actions side. And then, new hash_value issue is reported. I need to fix it. |
redboltz
force-pushed
the
sub_map_test
branch
from
08d4141 to
b5bafae
Compare
Owner
Author
|
I will ask you to rebase #688 from sub_map_test after I fixed the problem. |
redboltz
force-pushed
the
sub_map_test
branch
2 times, most recently
from
a5a9369 to
e4d0f0f
Compare
redboltz
force-pushed
the
sub_map_test
branch
from
e4d0f0f to
d2e512e
Compare
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
- Coverage 82.70% 82.23% -0.47%
==========================================
Files 46 47 +1
Lines 7082 7100 +18
==========================================
- Hits 5857 5839 -18
- Misses 1225 1261 +36 |
…th to insert and return whether element was inserted or already exists
…_map return the number of elements that were removed
Renamed insert_or_update and update from multiple_subscription_map bo…
It seems that memory swap happens.
The same macro is defined at Linux build. They are pure logical macros. It is good enough.
CI optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests forcused on using it on the broker.