Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tls close #357

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix tls close #357

merged 2 commits into from
Oct 8, 2024

Conversation

redboltz
Copy link
Owner

@redboltz redboltz commented Oct 8, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.31%. Comparing base (5b029eb) to head (58696ff).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nc_mqtt/predefined_layer/customized_ssl_stream.hpp 70.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   97.26%   97.31%   +0.05%     
==========================================
  Files         153      153              
  Lines        9474     9469       -5     
==========================================
  Hits         9215     9215              
+ Misses        259      254       -5     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/async_mqtt/impl/endpoint_close.hpp 98.48% <100.00%> (ø)
...nclude/async_mqtt/util/impl/stream_read_packet.hpp 98.55% <100.00%> (+<0.01%) ⬆️
...clude/async_mqtt/util/impl/stream_write_packet.hpp 97.19% <100.00%> (+0.02%) ⬆️
include/async_mqtt/util/ioc_queue.hpp 100.00% <100.00%> (ø)
...nc_mqtt/predefined_layer/customized_ssl_stream.hpp 82.35% <70.00%> (+7.93%) ⬆️

@redboltz
Copy link
Owner Author

redboltz commented Oct 8, 2024

Unified the point of self.complete() call. It fixes other close issue.
No regressions are detected #353

@redboltz redboltz merged commit d0966f1 into main Oct 8, 2024
11 checks passed
@redboltz redboltz deleted the fix_tls_close branch October 8, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants