Skip to content

Reimplement CPIO components using libarchive #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Reimplement CPIO components using libarchive #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f7a7e03
Reimplement the CPIO components using libarchive
Oct 3, 2025
8a0d82a
Add test for archive type preservation
Oct 3, 2025
842c64d
Lint
Oct 3, 2025
a79ce80
Pin version of libarchive-c. Add libarchive-dev to Dockerstub
Oct 3, 2025
94891a8
Update changelog
Oct 3, 2025
3876dfb
Ignore libarchive in mypy. Add requirement for libarchive in ofrak_co…
Oct 3, 2025
9048c18
Added comments about libarchive
Oct 6, 2025
74c6ce4
Support more OSes in libarchive check
Oct 6, 2025
59144dd
Apply suggestions from code review
paulnoalhyt Oct 6, 2025
a47b051
Merge branch 'master' into bugfix/cpio-libarchive
Oct 6, 2025
ffa0962
Pin newer version of libarchive-c python package
Oct 6, 2025
285159b
Remove cpio from Dockerfile
Oct 6, 2025
044d6ee
remove duplicate test
Oct 6, 2025
49a1e14
Remove test_character_device test, already handled in test_special_fi…
Oct 6, 2025
0fe103a
libarchive on Windows
Oct 7, 2025
617cfe8
fix symlinks in libarchive, added link to issue
Oct 8, 2025
a30e30c
Preserve rdev (character device number)
Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ofrak_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- When the user selects the "Decompilation" tab in the GUI, the pane is updated with the decompiled code automatically, without having to click "Analyze" first. ([#639](https://github.com/redballoonsecurity/ofrak/pull/639))
- Use a single source of truth for the package version ([#640](https://github.com/redballoonsecurity/ofrak/pull/640))
- Update the behavior of `get_only_descendant_as_view`, `get_descendants_as_view`, `get_ancestors_as_view`, and `get_only_ancestor_as_view` to retrieve all resources that match the filter. ([#642](https://github.com/redballoonsecurity/ofrak/pull/642))
- Reimplement the CPIO components using `libarchive` ([#647](https://github.com/redballoonsecurity/ofrak/pull/647))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to unreleased! You also need to bump the VERSION in ofrak_core/version.py.


### Deprecated
- `Resource.flush_to_disk` deprecated in favor of `Resource.flush_data_to_disk`. ([#373](https://github.com/redballoonsecurity/ofrak/pull/373), [#567](https://github.com/redballoonsecurity/ofrak/pull/568))
Expand Down
3 changes: 2 additions & 1 deletion ofrak_core/Dockerstub
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
ARG TARGETARCH
# - u-boot-tools: for mkimage, to test the UImage packer/unpacker
# - zlib1g-dev, liblzma-dev: development headers needed for squashfs-tools compilation
# - libarchive13: required for the CPIO components
RUN apt-get -y update && \
apt-get -y install --no-install-recommends \
build-essential \
cmake \
cpio \
git \
genisoimage \
liblz4-dev \
Expand All @@ -23,6 +23,7 @@ RUN apt-get -y update && \
unar \
unzip \
zstd \
libarchive13 \
&& rm -rf /var/lib/apt/lists/*

# python-lzo needed by ubireader
Expand Down
3 changes: 3 additions & 0 deletions ofrak_core/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,6 @@ ignore_missing_imports = True
# python-magic-bin on Windows doesn't include type stubs
[mypy-magic.*]
ignore_missing_imports = True

[mypy-libarchive.*]
ignore_missing_imports = True
2 changes: 2 additions & 0 deletions ofrak_core/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ tempfile312~=1.0.1
typeguard~=2.13.3
ubi-reader==0.8.12
xattr==0.10.1;platform_system!="Windows"
libarchive-c==5.3
extractcode-libarchive>=3.5.1.210531;platform_system=="Windows"
2 changes: 2 additions & 0 deletions ofrak_core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ class CTypesExtension(setuptools.Extension):
"typeguard~=2.13.3",
"ubi-reader>=0.8.12",
"xattr>=0.10.1;platform_system!='Windows'",
"libarchive-c>=5.3",
"extractcode-libarchive>=3.5.1.210531;platform_system=='Windows'",
],
author="Red Balloon Security",
author_email="ofrak@redballoonsecurity.com",
Expand Down
Loading
Loading