Unit Test mse decoder #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugpermar
suggested changes
Oct 24, 2016
src/decoder/mse/rb_mse.c
Outdated
| assert(opaque); | ||
| assert(config); | ||
| char err[BUFSIZ]; | ||
| char err[BUFSIZ] = ""; |
There was a problem hiding this comment.
This shouldn't be initialized
src/decoder/mse/rb_mse.c
Outdated
| assert(MSE_OPAQUE_MAGIC == opaque->magic); | ||
| #endif | ||
| char err[BUFSIZ]; | ||
| char err[BUFSIZ] = ""; |
There was a problem hiding this comment.
This shouldn't be initialized
src/decoder/mse/rb_mse.c
Outdated
| void mse_opaque_done(void *_opaque) { | ||
| assert(_opaque); | ||
|
|
||
| if (NULL == _opaque){ |
There was a problem hiding this comment.
_opaque should never be NULL (the previous assert & we are freeing data)
src/decoder/mse/rb_mse.c
Outdated
|
|
||
| json_array_foreach(mse_array, _index, value) { | ||
| parse_sensor(value, new_db); | ||
| ret = parse_sensor(value, new_db); |
There was a problem hiding this comment.
const int ret = parse_sensor
src/util/in_addr_list.c
Outdated
| int in_addr_list_contains(const in_addr_list_t *list,const struct in_addr *addr){ | ||
| in_addr_list_node_t *n=NULL; | ||
| for(n=LIST_FIRST(syslist(list));n!=NULL;n=LIST_NEXT(n,entry)){ | ||
| if (NULL == n){ |
There was a problem hiding this comment.
this can't be NULL (loop condition)
src/util/in_addr_list.c
Outdated
|
|
||
| in_addr_list_node_t *n=NULL; | ||
| while((n = LIST_FIRST(syslist(list)))){ | ||
| if (NULL == n){ |
There was a problem hiding this comment.
n can never be NULL (loop condition)
tests/0000-MSE8.c
Outdated
| mse_array); | ||
| assert_true(parse_rc == 0); | ||
|
|
||
| char *aux = strdup(mse_input1); |
There was a problem hiding this comment.
No need to strdup string, process_mse_buffer parameter is const
tests/0000-MSE8.c
Outdated
| &decoder_info, | ||
| now); | ||
|
|
||
| char *aux2 = strdup(mse_input2); |
| } | ||
|
|
||
| static void checkMSE8_invalid_timestamp(struct mse_array *notifications_array) { | ||
| /* No database -> output == input */ |
tests/0003-MSE8_listener_enrich.c
Outdated
| assert(unpack_rc == 0); | ||
| assert(0 == strcmp(subscriptionName, "MSE_SanCarlos")); | ||
| assert(0 == strcmp(sensor_name, "MSE_testing")); | ||
| //assert(0 == strcmp(sensor_name, "MSE_testing")); |
added 9 commits
October 27, 2016 11:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.