Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BZ 2283643] object: virtulhostnames is not required in the endpoint #663

Open
wants to merge 1 commit into
base: release-4.16
Choose a base branch
from

Conversation

thotz
Copy link

@thotz thotz commented Jun 4, 2024

The virtualhostnames for rgw is added to possible endpoint list, this endpoint is mainly used by rook operator for communicating with RGW server. If enable the virtualhostname feature for rgw, by default the service endpoint is added to the list. So the service endpoint can accessed even if the feature is enabled.

(cherry picked from commit b5d79d1efa4ef2b859af4dd2cf3aa72230105b4a)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

…for rgw

The virtualhostnames for rgw is added to possible endpoint list, this
endpoint is mainly used by rook operator for communicating with RGW
server. If enable the virtualhostname feature for rgw, by default the
service endpoint is added to the list. So the service endpoint can
accessed even if the feature is enabled.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit b5d79d1efa4ef2b859af4dd2cf3aa72230105b4a)
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Copy link

openshift-ci bot commented Jun 4, 2024

@thotz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[BZ 2283643] object: virtulhostnames is not required in the endpoint …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thotz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thotz thotz changed the title [BZ 2283643] object: virtulhostnames is not required in the endpoint … [BZ 2283643] object: virtulhostnames is not required in the endpoint Jun 4, 2024
Copy link

openshift-ci bot commented Jun 4, 2024

@thotz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[BZ 2283643] object: virtulhostnames is not required in the endpoint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
Copy link

openshift-ci bot commented Jun 4, 2024

@thotz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[BZ 2283643] object: virtulhostnames is not required in the endpoint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant