Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2307909: Fix disable dr when VR failed validation #369

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Bug 2307909: Fix disable dr when VR failed validation #369

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2ebfef0
Bump CSI version to 0.9.1
ELENAGER Sep 4, 2024
76dff84
Update csi-addons to v0.10.0 in drenv
nirs Sep 18, 2024
6f7c524
Update csi-addons requirement to v.0.10.0 in ramen
nirs Sep 18, 2024
a6f0f48
Add external-snapshotter addon to kubevirt envs
nirs Sep 24, 2024
06bac50
Reformat reconcileMissingVR comment for readability
nirs Sep 23, 2024
2ae656a
Fix logs in reconcileMissingVR
nirs Sep 23, 2024
90070b6
Extract VRGInstance.validateVRCompletedStatus()
nirs Sep 23, 2024
773a2e3
Clarify isVRConditionMet
nirs Sep 23, 2024
fbe9284
Improve logging in delete VR flow
nirs Sep 23, 2024
8689b8e
Fix disable dr if VR failed validation
nirs Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add external-snapshotter addon to kubevirt envs 
Was forgetten when we replaced minikube volumesnapshot addons.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
(cherry picked from commit 75aa24b)
  • Loading branch information
@nirs
nirs committed Oct 2, 2024
commit a6f0f48381c99b751f6d6517fae96a7946d06e15
1 change: 1 addition & 0 deletions test/envs/kubevirt.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ profiles:
disk_size: "50g"
workers:
- addons:
- name: external-snapshotter
- name: rook-operator
- name: rook-cluster
- name: rook-toolbox
Expand Down
1 change: 1 addition & 0 deletions test/envs/regional-dr-kubevirt.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ templates:
disk_size: "50g"
workers:
- addons:
- name: external-snapshotter
- name: rook-operator
- name: rook-cluster
- name: rook-toolbox
Expand Down